Changeset 200896 in webkit

Timestamp:

May 13, 2016, 4:44:31 PM (10 years ago)

Author:

benjamin@webkit.org

Message:

[JSC] Emit the loads of emitLoadWithStructureCheck() in the order they are used
​https://bugs.webkit.org/show_bug.cgi?id=157671

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-05-13
Reviewed by Mark Lam.

This improves the chances of having a value
when issuing the TEST.

• jit/JITPropertyAccess.cpp:

(JSC::JIT::emitLoadWithStructureCheck):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jit/JITPropertyAccess.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-05-13  Benjamin Poulain  <bpoulain@apple.com>
+
+        [JSC] Emit the loads of emitLoadWithStructureCheck() in the order they are used
+        https://bugs.webkit.org/show_bug.cgi?id=157671
+
+        Reviewed by Mark Lam.
+
+        This improves the chances of having a value
+        when issuing the TEST.
+
+        * jit/JITPropertyAccess.cpp:
+        (JSC::JIT::emitLoadWithStructureCheck):
+
 2016-05-13  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/JavaScriptCore/jit/JITPropertyAccess.cpp

@@ -802 +802 @@
 void JIT::emitLoadWithStructureCheck(int scope, Structure** structureSlot)
 {
+    loadPtr(structureSlot, regT1);
     emitGetVirtualRegister(scope, regT0);
-    loadPtr(structureSlot, regT1);
     addSlowCase(branchTestPtr(Zero, regT1));
     load32(Address(regT1, Structure::structureIDOffset()), regT1);