Changeset 201476 in webkit


Ignore:
Timestamp:
May 27, 2016, 5:07:35 PM (9 years ago)
Author:
Alan Bujtas
Message:

EventHandler finds incorrect scrollable container.
​https://bugs.webkit.org/show_bug.cgi?id=158132
<rdar://problem/26423126>

Reviewed by Brent Fulgham.

Fix the logic that checks whether we are at the beginning or at the end of the container (horizontally).
While scrolling to the right, deltaX has negative values. So in case of deltaX < 0, we need to check if
the container is not scrolled all the way to the right.

Source/WebCore:

Test: fast/scrolling/scroll-container-horizontally.html

  • page/mac/EventHandlerMac.mm:

(WebCore::findEnclosingScrollableContainer):

LayoutTests:

  • fast/scrolling/scroll-container-horizontally-expected.txt: Added.
  • fast/scrolling/scroll-container-horizontally.html: Added.
  • platform/ios-simulator/TestExpectations:
  • platform/mac-wk1/TestExpectations:
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r201473 r201476  
     12016-05-27  Zalan Bujtas  <zalan@apple.com>
     2
     3        EventHandler finds incorrect scrollable container.
     4        https://bugs.webkit.org/show_bug.cgi?id=158132
     5        <rdar://problem/26423126>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        Fix the logic that checks whether we are at the beginning or at the end of the container (horizontally).
     10        While scrolling to the right, deltaX has negative values. So in case of deltaX < 0, we need to check if
     11        the container is not scrolled all the way to the right.
     12
     13        * fast/scrolling/scroll-container-horizontally-expected.txt: Added.
     14        * fast/scrolling/scroll-container-horizontally.html: Added.
     15        * platform/ios-simulator/TestExpectations:
     16        * platform/mac-wk1/TestExpectations:
     17
    1182016-05-27  Saam barati  <sbarati@apple.com>
    219

  • trunk/LayoutTests/platform/ios-simulator/TestExpectations

    r201338 r201476  
    6363fast/events/wheel-event-destroys-overflow.html [ Skip ]
    6464fast/events/wheel-event-outside-body.html [ Skip ]
     65fast/scrolling/scroll-container-horizontally.html [ Failure ]
    6566
    6667# Not supported on iOS

  • trunk/LayoutTests/platform/mac-wk1/TestExpectations

    r201346 r201476  
    128128fast/scrolling/iframe-scrollable-after-back.html [ Skip ]
    129129fast/scrolling/overflow-scrollable-after-back.html [ Skip ]
     130fast/scrolling/scroll-container-horizontally.html [ Failure ]
    130131
    131132compositing/rtl/rtl-fixed-overflow-scrolled.html [ Failure ]

  • trunk/Source/WebCore/ChangeLog

    r201474 r201476  
     12016-05-27  Zalan Bujtas  <zalan@apple.com>
     2
     3        EventHandler finds incorrect scrollable container.
     4        https://bugs.webkit.org/show_bug.cgi?id=158132
     5        <rdar://problem/26423126>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        Fix the logic that checks whether we are at the beginning or at the end of the container (horizontally).
     10        While scrolling to the right, deltaX has negative values. So in case of deltaX < 0, we need to check if
     11        the container is not scrolled all the way to the right.
     12
     13        Test: fast/scrolling/scroll-container-horizontally.html
     14
     15        * page/mac/EventHandlerMac.mm:
     16        (WebCore::findEnclosingScrollableContainer):
     17
    1182016-05-27  Jeremy Jones  <jeremyj@apple.com>
    219

  • trunk/Source/WebCore/page/mac/EventHandlerMac.mm

    r201441 r201476  
    818818            if (ScrollableArea* scrollableArea = scrollableAreaForBox(*box)) {
    819819                if (((deltaY > 0) && !scrollableArea->scrolledToTop()) || ((deltaY < 0) && !scrollableArea->scrolledToBottom())
    820                     || ((deltaX > 0) && !scrollableArea->scrolledToRight()) || ((deltaX < 0) && !scrollableArea->scrolledToLeft())) {
     820                    || ((deltaX > 0) && !scrollableArea->scrolledToLeft()) || ((deltaX < 0) && !scrollableArea->scrolledToRight())) {
    821821                    return candidate;
    822822                }
Note: See TracChangeset for help on using the changeset viewer.