⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 201530 in webkit


Ignore:
Timestamp:
May 31, 2016, 2:59:03 PM (10 years ago)
Author:
jer.noble@apple.com
Message:

REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=158156
<rdar://problem/26519589>

Reviewed by Darin Adler.

Source/WebKit2:

Only increase the frame of the webView (to account for top content inset) in one dimension.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added.

(-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
(TestWebKitAPI::TEST):

Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit2/ChangeLog

    r201519 r201530  
     12016-05-31  Jer Noble  <jer.noble@apple.com>
     2
     3        REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
     4        https://bugs.webkit.org/show_bug.cgi?id=158156
     5        <rdar://problem/26519589>
     6
     7        Reviewed by Darin Adler.
     8
     9        Only increase the frame of the webView (to account for top content inset) in one dimension.
     10
     11        * UIProcess/mac/WKFullScreenWindowController.mm:
     12        (-[WKFullScreenWindowController enterFullScreen:]):
     13
    1142016-05-31  Chris Dumez  <cdumez@apple.com>
    215

  • trunk/Source/WebKit2/UIProcess/mac/WKFullScreenWindowController.mm

    r201405 r201530  
    241241    NSView *contentView = [[self window] contentView];
    242242    [_clipView addSubview:_webView positioned:NSWindowBelow relativeTo:nil];
    243     _webView.frame = NSInsetRect(contentView.bounds, 0, -_page->topContentInset());
     243    NSRect contentViewBounds = contentView.bounds;
     244    contentViewBounds.size.height += _page->topContentInset();
     245    _webView.frame = contentViewBounds;
    244246
    245247    makeResponderFirstResponderIfDescendantOfView(self.window, webWindowFirstResponder, _webView);

  • trunk/Tools/ChangeLog

    r201517 r201530  
     12016-05-31  Jer Noble  <jer.noble@apple.com>
     2
     3        REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
     4        https://bugs.webkit.org/show_bug.cgi?id=158156
     5        <rdar://problem/26519589>
     6
     7        Reviewed by Darin Adler.
     8
     9        * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
     10        * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added.
     11        * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added.
     12        (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
     13        (TestWebKitAPI::TEST):
     14
    1152016-05-31  Jon Lee  <jonlee@apple.com>
    216

  • trunk/Tools/TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj

    r201461 r201530  
    366366                CDC8E4961BC6F10800594FEC /* video-without-audio.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CDC8E48B1BC5C96200594FEC /* video-without-audio.html */; };
    367367                CDC8E4971BC6F10800594FEC /* video-without-audio.mp4 in Copy Resources */ = {isa = PBXBuildFile; fileRef = CDC8E48C1BC5C96200594FEC /* video-without-audio.mp4 */; };
     368                CDE195B41CFE0ADE0053D256 /* FullscreenTopContentInset.mm in Sources */ = {isa = PBXBuildFile; fileRef = CDE195B31CFE0ADE0053D256 /* FullscreenTopContentInset.mm */; };
     369                CDE195B51CFE0B880053D256 /* FullscreenTopContentInset.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CDE195B21CFE0ADE0053D256 /* FullscreenTopContentInset.html */; };
    368370                CE14F1A4181873B0001C2705 /* WillPerformClientRedirectToURLCrash.html in Copy Resources */ = {isa = PBXBuildFile; fileRef = CE14F1A2181873B0001C2705 /* WillPerformClientRedirectToURLCrash.html */; };
    369371                CE3524F81B1431F60028A7C5 /* TextFieldDidBeginAndEndEditing_Bundle.cpp in Sources */ = {isa = PBXBuildFile; fileRef = CE3524F21B142B8D0028A7C5 /* TextFieldDidBeginAndEndEditing_Bundle.cpp */; };
    … …  
    430432                                51714EB41CF8C78C004723C4 /* WebProcessKillIDBCleanup-1.html in Copy Resources */,
    431433                                51714EB51CF8C78C004723C4 /* WebProcessKillIDBCleanup-2.html in Copy Resources */,
     434                                CDE195B51CFE0B880053D256 /* FullscreenTopContentInset.html in Copy Resources */,
    432435                                93CFA8671CEB9E38000565A8 /* autofocused-text-input.html in Copy Resources */,
    433436                                93625D271CD9741C006DC1F1 /* large-video-without-audio.html in Copy Resources */,
    … …  
    907910                CDC8E48B1BC5C96200594FEC /* video-without-audio.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = "video-without-audio.html"; sourceTree = "<group>"; };
    908911                CDC8E48C1BC5C96200594FEC /* video-without-audio.mp4 */ = {isa = PBXFileReference; lastKnownFileType = file; path = "video-without-audio.mp4"; sourceTree = "<group>"; };
     912                CDE195B21CFE0ADE0053D256 /* FullscreenTopContentInset.html */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = text.html; path = FullscreenTopContentInset.html; sourceTree = "<group>"; };
     913                CDE195B31CFE0ADE0053D256 /* FullscreenTopContentInset.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = FullscreenTopContentInset.mm; sourceTree = "<group>"; };
    909914                CE14F1A2181873B0001C2705 /* WillPerformClientRedirectToURLCrash.html */ = {isa = PBXFileReference; lastKnownFileType = text.html; path = WillPerformClientRedirectToURLCrash.html; sourceTree = "<group>"; };
    910915                CE32C7C718184C4900CD8C28 /* WillPerformClientRedirectToURLCrash.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = WillPerformClientRedirectToURLCrash.mm; sourceTree = "<group>"; };
    … …  
    10651070                                2D8104CB1BEC13E70020DA46 /* FindInPage.mm */,
    10661071                                2D1FE0AF1AD465C1006CD9E6 /* FixedLayoutSize.mm */,
     1072                                CDE195B31CFE0ADE0053D256 /* FullscreenTopContentInset.mm */,
    10671073                                51BCEE491C84F4AF0042C82E /* IndexedDBMultiProcess.mm */,
    10681074                                51B1EE8D1C80F5880064FB98 /* IndexedDBPersistence.mm */,
    … …  
    11631169                        isa = PBXGroup;
    11641170                        children = (
     1171                                CDE195B21CFE0ADE0053D256 /* FullscreenTopContentInset.html */,
    11651172                                A16F66B91C40EA2000BD4D24 /* ContentFiltering.html */,
    11661173                                5714ECB81CA8B58800051AC8 /* DownloadRequestOriginalURL.html */,
    … …  
    20202027                                2E7765CD16C4D80A00BA2BB1 /* mainIOS.mm in Sources */,
    20212028                                2D8104CC1BEC13E70020DA46 /* FindInPage.mm in Sources */,
     2029                                CDE195B41CFE0ADE0053D256 /* FullscreenTopContentInset.mm in Sources */,
    20222030                                93E943F21CD3E87E00AC08C2 /* VideoControlsManager.mm in Sources */,
    20232031                                5798E2B01CAF5C2800C5CBA0 /* ProvisionalURLNotChange.mm in Sources */,
Note: See TracChangeset for help on using the changeset viewer.