Changeset 201566 in webkit

Timestamp:

Jun 1, 2016, 1:32:57 PM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r201488.
​https://bugs.webkit.org/show_bug.cgi?id=158268

Caused 23% regression on JetStream's crypto-md5 (Requested by
rniwa on #webkit).

Reverted changeset:

"[ESNext] Support trailing commas in function param lists"
​https://bugs.webkit.org/show_bug.cgi?id=158020
​http://trac.webkit.org/changeset/201488

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/parser-syntax-check-expected.txt (modified) (2 diffs)
• LayoutTests/js/script-tests/parser-syntax-check.js (modified) (2 diffs)
• LayoutTests/sputnik/Conformance/13_Function_Definition/S13_A5.html (modified) (1 diff)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/parser/Parser.cpp (modified) (2 diffs)
• Source/JavaScriptCore/tests/stress/trailing-comma-in-function-paramters.js (deleted)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-06-01  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r201488.
+        https://bugs.webkit.org/show_bug.cgi?id=158268
+
+        Caused 23% regression on JetStream's crypto-md5 (Requested by
+        rniwa on #webkit).
+
+        Reverted changeset:
+
+        "[ESNext] Support trailing commas in function param lists"
+        https://bugs.webkit.org/show_bug.cgi?id=158020
+        http://trac.webkit.org/changeset/201488
+
 2016-06-01  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
 

trunk/LayoutTests/js/parser-syntax-check-expected.txt

@@ -138 +138 @@
 PASS Invalid: "a(5,"
 PASS Invalid: "function f() { a(5, }"
-PASS Valid:   "a(5,)" with ReferenceError
-PASS Valid:   "function f() { a(5,) }"
+PASS Invalid: "a(5,)"
+PASS Invalid: "function f() { a(5,) }"
 PASS Invalid: "a(5,6"
 PASS Invalid: "function f() { a(5,6 }"
@@ -173 +173 @@
 PASS Invalid: "function f(a b) {}"
 PASS Invalid: "function f() { function f(a b) {} }"
-PASS Valid:   "function f(a,) {}"
-PASS Valid:   "function f() { function f(a,) {} }"
+PASS Invalid: "function f(a,) {}"
+PASS Invalid: "function f() { function f(a,) {} }"
 PASS Invalid: "function f(a,"
 PASS Invalid: "function f() { function f(a, }"

trunk/LayoutTests/js/script-tests/parser-syntax-check.js

@@ -148 +148 @@
 invalid("a(5");
 invalid("a(5,");
-valid("a(5,)");
+invalid("a(5,)");
 invalid("a(5,6");
 valid  ("a(b[7], c <d> e.l, new a() > b)");
@@ -168 +168 @@
 invalid("function () {}");
 invalid("function f(a b) {}");
-valid("function f(a,) {}");
+invalid("function f(a,) {}");
 invalid("function f(a,");
 invalid("function f(a, 1) {}");

trunk/LayoutTests/sputnik/Conformance/13_Function_Definition/S13_A5.html

@@ -101 +101 @@
 //CHECK#3
 try{
-        eval("function __func(arg1, arg2, arg3,,){return arguments.length;}");
-        testFailed('#3: eval("function __func(arg1, arg2, arg3,,){return arguments.length;}") lead to throwing exception')
+        eval("function __func(arg1, arg2, arg3,){return arguments.length;}");
+        testFailed('#3: eval("function __func(arg1, arg2, arg3,){return arguments.length;}") lead to throwing exception')
 } catch(e){
         if(!(e instanceof SyntaxError)){
-                testFailed('#3.1: eval("function __func(arg1, arg2, arg3,,){return arguments.length;}") lead to throwing exception of SyntaxError. Actual: exception is '+e);
+                testFailed('#3.1: eval("function __func(arg1, arg2, arg3,){return arguments.length;}") lead to throwing exception of SyntaxError. Actual: exception is '+e);
         }
 }

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-06-01  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r201488.
+        https://bugs.webkit.org/show_bug.cgi?id=158268
+
+        Caused 23% regression on JetStream's crypto-md5 (Requested by
+        rniwa on #webkit).
+
+        Reverted changeset:
+
+        "[ESNext] Support trailing commas in function param lists"
+        https://bugs.webkit.org/show_bug.cgi?id=158020
+        http://trac.webkit.org/changeset/201488
+
 2016-05-31  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/JavaScriptCore/parser/Parser.cpp

@@ -1747 +1747 @@
         TreeExpression defaultValue = 0;
 
-        if (match(CLOSEPAREN))
-            break;
-        
         if (match(DOTDOTDOT)) {
             next();
@@ -3830 +3827 @@
         next(TreeBuilder::DontBuildStrings);
 
-        if (match(CLOSEPAREN))
-            break;
-        
         TreeExpression arg = parseArgument(context, argType);
         propagateError();