Changeset 201567 in webkit

Timestamp:

Jun 1, 2016, 1:55:30 PM (10 years ago)

Author:

jer.noble@apple.com

Message:

setVideoFullscreenGravity() has no effect on the fullscreen video layer
​https://bugs.webkit.org/show_bug.cgi?id=158267

Reviewed by Eric Carlson.

When we moved to a 2-AVPlayerLayer solution, we didn't update setVideoFullscreenGravity()
to change the correct layer's videoGravity property.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-01  Jer Noble  <jer.noble@apple.com>
+
+        setVideoFullscreenGravity() has no effect on the fullscreen video layer
+        https://bugs.webkit.org/show_bug.cgi?id=158267
+
+        Reviewed by Eric Carlson.
+
+        When we moved to a 2-AVPlayerLayer solution, we didn't update setVideoFullscreenGravity()
+        to change the correct layer's videoGravity property.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+        (WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity):
+
 2016-06-01  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

@@ -1219 +1219 @@
 {
     m_videoFullscreenGravity = gravity;
-    if (!m_videoLayer)
+
+    auto activeLayer = m_secondaryVideoLayer.get() ?: m_videoLayer.get();
+    if (!activeLayer)
         return;
 
@@ -1232 +1234 @@
         ASSERT_NOT_REACHED();
     
-    if ([m_videoLayer videoGravity] == videoGravity)
-        return;
-
-    [m_videoLayer setVideoGravity:videoGravity];
+    if ([activeLayer videoGravity] == videoGravity)
+        return;
+
+    [activeLayer setVideoGravity:videoGravity];
     syncTextTrackBounds();
 }