Changeset 201574 in webkit

Timestamp:

Jun 1, 2016, 3:49:07 PM (10 years ago)

Author:

eric.carlson@apple.com

Message:

REGRESSION(r201385) ASSERT in WebCore::HTMLMediaElement::updateActiveTextTrackCues + 5688
​https://bugs.webkit.org/show_bug.cgi?id=158164
<rdar://problem/26498634>

Reviewed by Jer Noble.

No new tests, this prevents an assert in existing tests.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Call beginIgnoringTrackDisplayUpdateRequests

so we avoid doing unnecessary work triggered by destruction.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-01  Eric Carlson  <eric.carlson@apple.com>
+
+        REGRESSION(r201385) ASSERT in WebCore::HTMLMediaElement::updateActiveTextTrackCues + 5688
+        https://bugs.webkit.org/show_bug.cgi?id=158164
+        <rdar://problem/26498634>
+
+        Reviewed by Jer Noble.
+
+        No new tests, this prevents an assert in existing tests.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::~HTMLMediaElement): Call beginIgnoringTrackDisplayUpdateRequests
+          so we avoid doing unnecessary work triggered by destruction.
+
 2016-06-01  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -498 +498 @@
     LOG(Media, "HTMLMediaElement::~HTMLMediaElement(%p)", this);
 
+    beginIgnoringTrackDisplayUpdateRequests();
     allMediaElements().remove(this);