Changeset 201579 in webkit

Timestamp:

Jun 1, 2016, 5:23:59 PM (10 years ago)

Author:

Chris Dumez

Message:

Use HashMap::ensure() in DocumentOrderedMap::add()
​https://bugs.webkit.org/show_bug.cgi?id=158283

Reviewed by Ryosuke Niwa.

Use HashMap::ensure() in DocumentOrderedMap::add() to avoid constructing
a MapEntry if the key is already present in the HashMap.

• dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::add):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/DocumentOrderedMap.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-01  Chris Dumez  <cdumez@apple.com>
+
+        Use HashMap::ensure() in DocumentOrderedMap::add()
+        https://bugs.webkit.org/show_bug.cgi?id=158283
+
+        Reviewed by Ryosuke Niwa.
+
+        Use HashMap::ensure() in DocumentOrderedMap::add() to avoid constructing
+        a MapEntry if the key is already present in the HashMap.
+
+        * dom/DocumentOrderedMap.cpp:
+        (WebCore::DocumentOrderedMap::add):
+
 2016-06-01  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebCore/dom/DocumentOrderedMap.cpp

@@ -55 +55 @@
     if (!element.isInTreeScope())
         return;
-    Map::AddResult addResult = m_map.add(&key, MapEntry(&element));
+    Map::AddResult addResult = m_map.ensure(&key, [&element] {
+        return MapEntry(&element);
+    });
     MapEntry& entry = addResult.iterator->value;