Changeset 201611 in webkit

Timestamp:

Jun 2, 2016, 12:40:20 PM (10 years ago)

Author:

fpizlo@apple.com

Message:

Use "= delete" for Locker(int)

Rubber stamped by Saam Barati.
Source/JavaScriptCore:

• runtime/ConcurrentJITLock.h:

(JSC::ConcurrentJITLocker::ConcurrentJITLocker):

Source/WTF:

See discussion: ​https://bugs.webkit.org/show_bug.cgi?id=158306#c8

• wtf/Locker.h:

(WTF::Locker::Locker):
(WTF::Locker::~Locker):

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/runtime/ConcurrentJITLock.h (modified) (1 diff)
• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/Locker.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-06-02  Filip Pizlo  <fpizlo@apple.com>
+
+        Use "= delete" for Locker(int) 
+
+        Rubber stamped by Saam Barati.
+
+        * runtime/ConcurrentJITLock.h:
+        (JSC::ConcurrentJITLocker::ConcurrentJITLocker):
+
 2016-06-02  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/JavaScriptCore/runtime/ConcurrentJITLock.h

@@ -133 +133 @@
     }
     
-    NO_RETURN_DUE_TO_CRASH ConcurrentJITLocker(int)
-        : ConcurrentJITLockerBase(NoLockingNecessary)
-#if ENABLE(CONCURRENT_JIT) && !defined(NDEBUG)
-        , m_disallowGC(Nullopt)
-#endif
-    {
-        RELEASE_ASSERT_NOT_REACHED();
-    }
+    ConcurrentJITLocker(int) = delete;
 
 #if ENABLE(CONCURRENT_JIT) && !defined(NDEBUG)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2016-06-02  Filip Pizlo  <fpizlo@apple.com>
+
+        Use "= delete" for Locker(int) 
+
+        Rubber stamped by Saam Barati.
+        
+        See discussion: https://bugs.webkit.org/show_bug.cgi?id=158306#c8
+
+        * wtf/Locker.h:
+        (WTF::Locker::Locker):
+        (WTF::Locker::~Locker):
+
 2016-06-02  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/WTF/wtf/Locker.h

@@ -49 +49 @@
     Locker(NoLockingNecessaryTag) : m_lockable(nullptr) { }
     
-    NO_RETURN_DUE_TO_CRASH Locker(int)
-    {
-        RELEASE_ASSERT_NOT_REACHED();
-    }
+    Locker(int) = delete;
 
     ~Locker()