Changeset 201656 in webkit

Timestamp:

Jun 3, 2016, 2:13:34 PM (10 years ago)

Author:

benjamin@webkit.org

Message:

Fix some more INFINITI->INFINITY typos

Unreviewed.

The tests were not covering the edge cases they were supposed to test.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-03

• tests/stress/math-ceil-basics.js:

(testMathCeilOnConstants):

• tests/stress/math-clz32-basics.js:

(testMathClz32OnDoubles):
(testMathClz32OnConstants):

• tests/stress/math-floor-basics.js:

(testMathFloorOnConstants):

• tests/stress/math-round-basics.js:

(testMathRoundOnConstants):

• tests/stress/math-trunc-basics.js:

(testMathTruncOnConstants):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• tests/stress/math-ceil-basics.js (modified) (1 diff)
• tests/stress/math-clz32-basics.js (modified) (2 diffs)
• tests/stress/math-floor-basics.js (modified) (1 diff)
• tests/stress/math-round-basics.js (modified) (1 diff)
• tests/stress/math-trunc-basics.js (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-06-03  Benjamin Poulain  <bpoulain@apple.com>
+
+        Fix some more INFINITI->INFINITY typos
+
+        Unreviewed.
+
+        The tests were not covering the edge cases they were supposed to test.
+
+        * tests/stress/math-ceil-basics.js:
+        (testMathCeilOnConstants):
+        * tests/stress/math-clz32-basics.js:
+        (testMathClz32OnDoubles):
+        (testMathClz32OnConstants):
+        * tests/stress/math-floor-basics.js:
+        (testMathFloorOnConstants):
+        * tests/stress/math-round-basics.js:
+        (testMathRoundOnConstants):
+        * tests/stress/math-trunc-basics.js:
+        (testMathTruncOnConstants):
+
 2016-06-02  Gavin & Ellie Barraclough  <barraclough@apple.com>
 

trunk/Source/JavaScriptCore/tests/stress/math-ceil-basics.js

@@ -221 +221 @@
     if (value === value)
         throw new Error("Math.ceil(NaN) = " + value);
-    var value = Math.ceil(Number.POSITIVE_INFINITI);
-    if (value === value)
-        throw new Error("Math.ceil(Number.POSITIVE_INFINITI) = " + value);
-    var value = Math.ceil(Number.NEGATIVE_INFINITI);
-    if (value === value)
-        throw new Error("Math.ceil(Number.NEGATIVE_INFINITI) = " + value);
+    var value = Math.ceil(Number.POSITIVE_INFINITY);
+    if (value !== Infinity)
+        throw new Error("Math.ceil(Number.POSITIVE_INFINITY) = " + value);
+    var value = Math.ceil(Number.NEGATIVE_INFINITY);
+    if (value !== -Infinity)
+        throw new Error("Math.ceil(Number.NEGATIVE_INFINITY) = " + value);
     var value = Math.ceil(Math.E);
     if (value !== 3)

trunk/Source/JavaScriptCore/tests/stress/math-clz32-basics.js

@@ -96 +96 @@
         throw "mathClz32OnDouble(NaN) = " + value;
 
-    var value = mathClz32OnDouble(Number.POSITIVE_INFINITI);
-    if (value != 32)
-        throw "mathClz32OnDouble(Number.POSITIVE_INFINITI) = " + value;
-
-    var value = mathClz32OnDouble(Number.NEGATIVE_INFINITI);
-    if (value != 32)
-        throw "mathClz32OnDouble(Number.NEGATIVE_INFINITI) = " + value;
+    var value = mathClz32OnDouble(Number.POSITIVE_INFINITY);
+    if (value != 32)
+        throw "mathClz32OnDouble(Number.POSITIVE_INFINITY) = " + value;
+
+    var value = mathClz32OnDouble(Number.NEGATIVE_INFINITY);
+    if (value != 32)
+        throw "mathClz32OnDouble(Number.NEGATIVE_INFINITY) = " + value;
 }
 noInline(testMathClz32OnDoubles);
@@ -186 +186 @@
     if (value !== 32)
         throw "Math.clz32(NaN) = " + value;
-    var value = Math.clz32(Number.POSITIVE_INFINITI);
-    if (value !== 32)
-        throw "Math.clz32(Number.POSITIVE_INFINITI) = " + value;
-    var value = Math.clz32(Number.NEGATIVE_INFINITI);
-    if (value !== 32)
-        throw "Math.clz32(Number.NEGATIVE_INFINITI) = " + value;
+    var value = Math.clz32(Number.POSITIVE_INFINITY);
+    if (value !== 32)
+        throw "Math.clz32(Number.POSITIVE_INFINITY) = " + value;
+    var value = Math.clz32(Number.NEGATIVE_INFINITY);
+    if (value !== 32)
+        throw "Math.clz32(Number.NEGATIVE_INFINITY) = " + value;
     var value = Math.clz32(Math.E);
     if (value !== 30)

trunk/Source/JavaScriptCore/tests/stress/math-floor-basics.js

@@ -221 +221 @@
     if (value === value)
         throw new Error("Math.floor(NaN) = " + value);
-    var value = Math.floor(Number.POSITIVE_INFINITI);
-    if (value === value)
-        throw new Error("Math.floor(Number.POSITIVE_INFINITI) = " + value);
-    var value = Math.floor(Number.NEGATIVE_INFINITI);
-    if (value === value)
-        throw new Error("Math.floor(Number.NEGATIVE_INFINITI) = " + value);
+    var value = Math.floor(Number.POSITIVE_INFINITY);
+    if (value !== Infinity)
+        throw new Error("Math.floor(Number.POSITIVE_INFINITY) = " + value);
+    var value = Math.floor(Number.NEGATIVE_INFINITY);
+    if (value !== -Infinity)
+        throw new Error("Math.floor(Number.NEGATIVE_INFINITY) = " + value);
     var value = Math.floor(Math.E);
     if (value !== 2)

trunk/Source/JavaScriptCore/tests/stress/math-round-basics.js

@@ -221 +221 @@
     if (value === value)
         throw "Math.round(NaN) = " + value;
-    var value = Math.round(Number.POSITIVE_INFINITI);
-    if (value === value)
-        throw "Math.round(Number.POSITIVE_INFINITI) = " + value;
-    var value = Math.round(Number.NEGATIVE_INFINITI);
-    if (value === value)
-        throw "Math.round(Number.NEGATIVE_INFINITI) = " + value;
+    var value = Math.round(Number.POSITIVE_INFINITY);
+    if (value !== Infinity)
+        throw "Math.round(Number.POSITIVE_INFINITY) = " + value;
+    var value = Math.round(Number.NEGATIVE_INFINITY);
+    if (value !== -Infinity)
+        throw "Math.round(Number.NEGATIVE_INFINITY) = " + value;
     var value = Math.round(Math.E);
     if (value !== 3)

trunk/Source/JavaScriptCore/tests/stress/math-trunc-basics.js

@@ -220 +220 @@
     if (value === value)
         throw new Error("Math.trunc(NaN) = " + value);
-    var value = Math.trunc(Number.POSITIVE_INFINITI);
-    if (value === value)
-        throw new Error("Math.trunc(Number.POSITIVE_INFINITI) = " + value);
-    var value = Math.trunc(Number.NEGATIVE_INFINITI);
-    if (value === value)
-        throw new Error("Math.trunc(Number.NEGATIVE_INFINITI) = " + value);
+    var value = Math.trunc(Number.POSITIVE_INFINITY);
+    if (value !== Infinity)
+        throw new Error("Math.trunc(Number.POSITIVE_INFINITY) = " + value);
+    var value = Math.trunc(Number.NEGATIVE_INFINITY);
+    if (value !== -Infinity)
+        throw new Error("Math.trunc(Number.NEGATIVE_INFINITY) = " + value);
     var value = Math.trunc(Math.E);
     if (value !== 2)