Changeset 201839 in webkit

Timestamp:

Jun 8, 2016, 4:02:39 PM (10 years ago)

Author:

BJ Burg

Message:

Uncaught Exception in TimelineDataGrid._updatePopoverForSelectedNode()
​https://bugs.webkit.org/show_bug.cgi?id=158502
<rdar://problem/26687038>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
It appears that this expression was moved around since it accesses
targetFrame before it's initialized. Check rect.size.height directly.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/TimelineDataGrid.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-06-08  Brian Burg  <bburg@apple.com>
+
+        Uncaught Exception in TimelineDataGrid._updatePopoverForSelectedNode()
+        https://bugs.webkit.org/show_bug.cgi?id=158502
+        <rdar://problem/26687038>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/TimelineDataGrid.js:
+        (WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):
+        It appears that this expression was moved around since it accesses
+        targetFrame before it's initialized. Check rect.size.height directly.
+
 2016-06-08  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/TimelineDataGrid.js

@@ -490 +490 @@
         // The element might be hidden if it does not have a width and height.
         let rect = WebInspector.Rect.rectFromClientRect(targetPopoverElement.getBoundingClientRect());
-        if (!rect.size.width && !targetFrame.rect.height)
+        if (!rect.size.width && !rect.size.height)
             return;