Changeset 201843 in webkit

Timestamp:

Jun 8, 2016, 4:17:11 PM (10 years ago)

Author:

BJ Burg

Message:

Web Inspector: an error is encountered when trying to delete nodes that have children
​https://bugs.webkit.org/show_bug.cgi?id=158541
<rdar://problem/26705901>

Reviewed by Timothy Hatcher.

• UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype.adjustCollapsedRange):
Offset into the array variable instead of a variable holding its length.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DOMTreeElement.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2016-06-08  Brian Burg  <bburg@apple.com>
+
+        Web Inspector: an error is encountered when trying to delete nodes that have children
+        https://bugs.webkit.org/show_bug.cgi?id=158541
+        <rdar://problem/26705901>
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Views/DOMTreeElement.js:
+        (WebInspector.DOMTreeElement.prototype.adjustCollapsedRange):
+        Offset into the array variable instead of a variable holding its length.
+
 2016-06-08  Brian Burg  <bburg@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js

@@ -451 +451 @@
         // In case some nodes from the expanded range were removed, pull some nodes from the collapsed range into the expanded range at the bottom.
         for (var i = this.expandedChildCount, limit = Math.min(this.expandedChildrenLimit, totalChildrenCount); i < limit; ++i)
-            this.insertChildElement(totalChildrenCount[i], i);
+            this.insertChildElement(visibleChildren[i], i);
 
         var expandedChildCount = this.expandedChildCount;