Changeset 201871 in webkit

Timestamp:

Jun 9, 2016, 10:31:08 AM (10 years ago)

Author:

beidson@apple.com

Message:

LayoutTest storage/indexeddb/modern/handle-user-delete.html is a flaky failure.
​https://bugs.webkit.org/show_bug.cgi?id=158501

Reviewed by Darin Adler.

The order in which the transaction abort happens doesn't matter; It only matters that it happens.

Update the test to reflect this.

• storage/indexeddb/modern/handle-user-delete-expected.txt:
• storage/indexeddb/modern/resources/handle-user-delete.js:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• storage/indexeddb/modern/handle-user-delete-expected.txt (modified) (1 diff)
• storage/indexeddb/modern/resources/handle-user-delete.js (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-06-09  Brady Eidson  <beidson@apple.com>
+
+        LayoutTest storage/indexeddb/modern/handle-user-delete.html is a flaky failure.
+        https://bugs.webkit.org/show_bug.cgi?id=158501
+
+        Reviewed by Darin Adler.
+        
+        The order in which the transaction abort happens doesn't matter; It only matters that it happens.
+        
+        Update the test to reflect this.
+        
+        * storage/indexeddb/modern/handle-user-delete-expected.txt:
+        * storage/indexeddb/modern/resources/handle-user-delete.js:
+
 2016-06-09  Simon Fraser  <simon.fraser@apple.com>
 

trunk/LayoutTests/storage/indexeddb/modern/handle-user-delete-expected.txt

@@ -11 +11 @@
 Started two spinning requests
 Requested clearAllDatabases
-Initial upgrade versionchange transaction aborted: [object DOMError]
 [PASS] Both requests hit a failure condition (Received onerror or failed to start a new request because the transaction was aborted)
 [PASS] Database received correct error.
+[PASS] Transaction aborted.
 PASS successfullyParsed is true
 

trunk/LayoutTests/storage/indexeddb/modern/resources/handle-user-delete.js

@@ -5 +5 @@
 var requestErrorCount = 0;
 var databaseError = false;
+var transactionAbort = false;
 
 function done()
@@ -17 +18 @@
     else
         log("[FAIL] Database did not receive correct error.");
-        
+
+    if (transactionAbort)
+        log("[PASS] Transaction aborted.");
+    else
+        log("[FAIL] Transaction did not abort.");
+
     finishJSTest();
 }
@@ -28 +34 @@
 function maybeFinish()
 {
-    if (requestErrorCount == 2 && databaseError)
+    if (requestErrorCount == 2 && databaseError && transactionAbort)
         done();
 }
@@ -78 +84 @@
 
     versionTransaction.onabort = function(event) {
-        log("Initial upgrade versionchange transaction aborted: " + versionTransaction.error);
+        transactionAbort = true;
+                maybeFinish();
     }