Changeset 201876 in webkit

Timestamp:

Jun 9, 2016, 11:47:21 AM (10 years ago)

Author:

Chris Dumez

Message:

WorkerGlobalScope attributes / operations should be on the prototype
​https://bugs.webkit.org/show_bug.cgi?id=158568
<rdar://problem/26720079>

Reviewed by Geoffrey Garen.

Source/WebCore:

WorkerGlobalScope attributes / operations should be on the prototype
because WorkerGlobalScope is not marked as [Global] / [PrimaryGlobal]:

• ​https://html.spec.whatwg.org/multipage/workers.html#the-workerglobalscope-common-interface
• ​http://heycam.github.io/webidl/#es-attributes
• ​http://heycam.github.io/webidl/#es-operations

DedicatedWorkerGlobalScope is the interface that is marked as [Global]
and whose attributes / operations should be on the instance.

This brings the number of failures on ​http://w3c-test.org/workers/interfaces.worker
from 65 to 34. It also aligns our behavior with Firefox and Chrome.

Test: fast/workers/WorkerGlobalScope-properties-prototype.html

• bindings/scripts/CodeGeneratorJS.pm:

(InterfaceRequiresAttributesOnInstance):
(OperationShouldBeOnInstance):

LayoutTests:

• fast/workers/WorkerGlobalScope-properties-prototype-expected.txt: Added.
• fast/workers/WorkerGlobalScope-properties-prototype.html: Added.

Add layout test coverage.

• fast/workers/self-hasOwnProperty-expected.txt:
• fast/workers/self-hasOwnProperty.html:

Update test I added a couple of days ago because it wrongly expected
the 'navigator' property to be on the instance. This check was failing
in other browsers (Firefox and Chrome).

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/workers/WorkerGlobalScope-properties-prototype-expected.txt (added)
• LayoutTests/fast/workers/WorkerGlobalScope-properties-prototype.html (added)
• LayoutTests/fast/workers/self-hasOwnProperty-expected.txt (modified) (1 diff)
• LayoutTests/fast/workers/self-hasOwnProperty.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/bindings/scripts/CodeGeneratorJS.pm (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-06-09  Chris Dumez  <cdumez@apple.com>
+
+        WorkerGlobalScope attributes / operations should be on the prototype
+        https://bugs.webkit.org/show_bug.cgi?id=158568
+        <rdar://problem/26720079>
+
+        Reviewed by Geoffrey Garen.
+
+        * fast/workers/WorkerGlobalScope-properties-prototype-expected.txt: Added.
+        * fast/workers/WorkerGlobalScope-properties-prototype.html: Added.
+        Add layout test coverage.
+
+        * fast/workers/self-hasOwnProperty-expected.txt:
+        * fast/workers/self-hasOwnProperty.html:
+        Update test I added a couple of days ago because it wrongly expected
+        the 'navigator' property to be on the instance. This check was failing
+        in other browsers (Firefox and Chrome).
+
 2016-06-09  Tim Horton  <timothy_horton@apple.com>
 

trunk/LayoutTests/fast/workers/self-hasOwnProperty-expected.txt

@@ -6 +6 @@
 self.hasOwnProperty('DedicatedWorkerGlobalScope'): true
 self.hasOwnProperty('WorkerGlobalScope'): true
-self.hasOwnProperty('navigator'): true
+self.hasOwnProperty('postMessage'): true
 PASS successfullyParsed is true
 

trunk/LayoutTests/fast/workers/self-hasOwnProperty.html

@@ -11 +11 @@
 worker.postMessage("eval self.hasOwnProperty('DedicatedWorkerGlobalScope')");
 worker.postMessage("eval self.hasOwnProperty('WorkerGlobalScope')");
-worker.postMessage("eval self.hasOwnProperty('navigator')");
+worker.postMessage("eval self.hasOwnProperty('postMessage')");
 worker.postMessage("eval DONE");
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-06-09  Chris Dumez  <cdumez@apple.com>
+
+        WorkerGlobalScope attributes / operations should be on the prototype
+        https://bugs.webkit.org/show_bug.cgi?id=158568
+        <rdar://problem/26720079>
+
+        Reviewed by Geoffrey Garen.
+
+        WorkerGlobalScope attributes / operations should be on the prototype
+        because WorkerGlobalScope is not marked as [Global] / [PrimaryGlobal]:
+        - https://html.spec.whatwg.org/multipage/workers.html#the-workerglobalscope-common-interface
+        - http://heycam.github.io/webidl/#es-attributes
+        - http://heycam.github.io/webidl/#es-operations
+
+        DedicatedWorkerGlobalScope is the interface that is marked as [Global]
+        and whose attributes / operations should be on the instance.
+
+        This brings the number of failures on http://w3c-test.org/workers/interfaces.worker
+        from 65 to 34. It also aligns our behavior with Firefox and Chrome.
+
+        Test: fast/workers/WorkerGlobalScope-properties-prototype.html
+
+        * bindings/scripts/CodeGeneratorJS.pm:
+        (InterfaceRequiresAttributesOnInstance):
+        (OperationShouldBeOnInstance):
+
 2016-06-09  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

@@ -559 +559 @@
     return 1 if $interface->isException;
 
-    return 1 if IsDOMGlobalObject($interface);
+    # FIXME: Add support for [PrimaryGlobal] / [Global].
+    return 1 if IsDOMGlobalObject($interface) && $interface->name ne "WorkerGlobalScope";
 
     return 1 if InterfaceRequiresAttributesOnInstanceForCompatibility($interface);
@@ -597 +598 @@
     my $function = shift;
 
-    return 1 if IsDOMGlobalObject($interface);
+    # FIXME: Add support for [PrimaryGlobal] / [Global].
+    return 1 if IsDOMGlobalObject($interface) && $interface->name ne "WorkerGlobalScope";
 
     # FIXME: The bindings generator does not support putting runtime-enabled operations on the instance yet (except for global objects).