Changeset 201879 in webkit

Timestamp:

Jun 9, 2016, 1:09:21 PM (10 years ago)

Author:

Michael Catanzaro

Message:

Add comments to clarify feature enablement
​https://bugs.webkit.org/show_bug.cgi?id=158567

Reviewed by Alex Christensen.

.:

• Source/cmake/WebKitFeatures.cmake:

Tools:

• Scripts/webkitperl/FeatureList.pm:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/cmake/WebKitFeatures.cmake (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/Scripts/webkitperl/FeatureList.pm (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2016-06-09  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Add comments to clarify feature enablement
+        https://bugs.webkit.org/show_bug.cgi?id=158567
+
+        Reviewed by Alex Christensen.
+
+        * Source/cmake/WebKitFeatures.cmake:
+
 2016-06-08  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/cmake/WebKitFeatures.cmake

@@ +1 @@
+# The settings in this file are the WebKit project default values, and
+# are recommended for most ports. Ports can override these settings in
+# Options*.cmake, but should do so only if there is strong reason to
+# deviate from the defaults of the WebKit project (e.g. if the feature
+# requires platform-specific implementation that does not exist).
+#
+# Most defaults in this file affect end users but not developers.
+# Defaults for development builds are set in FeatureList.pm. Most all
+# features enabled here should also be enabled in FeatureList.pm.
+
 set(_WEBKIT_AVAILABLE_OPTIONS "")
 

trunk/Tools/ChangeLog

@@ +1 @@
+2016-06-09  Michael Catanzaro  <mcatanzaro@igalia.com>
+
+        Add comments to clarify feature enablement
+        https://bugs.webkit.org/show_bug.cgi?id=158567
+
+        Reviewed by Alex Christensen.
+
+        * Scripts/webkitperl/FeatureList.pm:
+
 2016-06-09  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Tools/Scripts/webkitperl/FeatureList.pm

@@ -24 +24 @@
 
 # A module to contain all the enable/disable feature option code.
+#
+# For CMake ports, this module only affects development builds. The
+# settings in this file have ZERO EFFECT for end users. Use
+# WebKitFeatures.cmake to change settings for users. Guidelines:
+#
+# * A feature enabled here but not WebKitFeatures.cmake is EXPERIMENTAL.
+# * A feature enabled in WebKitFeatures.cmake but not here is a BUG.
 
 use strict;