Changeset 202916 in webkit

Timestamp:

Jul 7, 2016, 10:27:17 AM (10 years ago)

Author:

benjamin@webkit.org

Message:

[JSC] String.prototype.normalize should have a length of zero
​https://bugs.webkit.org/show_bug.cgi?id=159506

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

Spec: ​https://tc39.github.io/ecma262/#sec-string.prototype.normalize
The argument is optional, the length should be zero.

• runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

LayoutTests:

• js/script-tests/string-normalize.js: Added.

(listener.toString):

• js/string-normalize-expected.txt: Added.
• js/string-normalize.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/script-tests/string-normalize.js (added)
• LayoutTests/js/string-normalize-expected.txt (added)
• LayoutTests/js/string-normalize.html (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/StringPrototype.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-07-07  Benjamin Poulain  <benjamin@webkit.org>
+
+        [JSC] String.prototype.normalize should have a length of zero
+        https://bugs.webkit.org/show_bug.cgi?id=159506
+
+        Reviewed by Yusuke Suzuki.
+
+        * js/script-tests/string-normalize.js: Added.
+        (listener.toString):
+        * js/string-normalize-expected.txt: Added.
+        * js/string-normalize.html: Added.
+
 2016-07-07  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-07-07  Benjamin Poulain  <benjamin@webkit.org>
+
+        [JSC] String.prototype.normalize should have a length of zero
+        https://bugs.webkit.org/show_bug.cgi?id=159506
+
+        Reviewed by Yusuke Suzuki.
+
+        Spec: https://tc39.github.io/ecma262/#sec-string.prototype.normalize
+        The argument is optional, the length should be zero.
+
+        * runtime/StringPrototype.cpp:
+        (JSC::StringPrototype::finishCreation):
+
 2016-07-07  Csaba Osztrogonác  <ossy@webkit.org>
 

trunk/Source/JavaScriptCore/runtime/StringPrototype.cpp

@@ -174 +174 @@
     JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION("endsWith", stringProtoFuncEndsWith, DontEnum, 1);
     JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION("includes", stringProtoFuncIncludes, DontEnum, 1);
-    JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION("normalize", stringProtoFuncNormalize, DontEnum, 1);
+    JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION("normalize", stringProtoFuncNormalize, DontEnum, 0);
     JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->iteratorSymbol, stringProtoFuncIterator, DontEnum, 0);