Changeset 202918 in webkit

Timestamp:

Jul 7, 2016, 11:00:49 AM (10 years ago)

Author:

jer.noble@apple.com

Message:

Facebook videos without audio tracks will sometimes cause playback controls to appear.
​https://bugs.webkit.org/show_bug.cgi?id=159437

Reviewed by Eric Carlson.

Because updatePlaybackControlsManager() will cause the session manager to walk through all
the outstanding sessions asking if it canControlControlsManager(), some sessions will say
they can control the controls manager if we are currently processing a user gesture. This is
obviously not intended (there may be a user gesture to un-mute video 1, but an unrelated
video 2 should not be allowed to use that use gesture to fulfill its own requirements.)

So in those situations where conditions may have changed and updatePlaybackControlsManager()
needs to be called, instead schedule the update for the next run loop.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::layoutSizeChanged):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::scheduleUpdatePlaybackControlsManager):

• html/HTMLMediaElement.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (9 diffs)
• html/HTMLMediaElement.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-05  Jer Noble  <jer.noble@apple.com>
+
+        Facebook videos without audio tracks will sometimes cause playback controls to appear.
+        https://bugs.webkit.org/show_bug.cgi?id=159437
+
+        Reviewed by Eric Carlson.
+
+        Because updatePlaybackControlsManager() will cause the session manager to walk through all
+        the outstanding sessions asking if it canControlControlsManager(), some sessions will say
+        they can control the controls manager if we are currently processing a user gesture. This is
+        obviously not intended (there may be a user gesture to un-mute video 1, but an unrelated
+        video 2 should not be allowed to use that use gesture to fulfill its own requirements.)
+
+        So in those situations where conditions may have changed and updatePlaybackControlsManager()
+        needs to be called, instead schedule the update for the next run loop.
+        
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::setMuted):
+        (WebCore::HTMLMediaElement::layoutSizeChanged):
+        (WebCore::HTMLMediaElement::updatePlayState):
+        (WebCore::HTMLMediaElement::createMediaPlayer):
+        (WebCore::HTMLMediaElement::scheduleUpdatePlaybackControlsManager):
+        * html/HTMLMediaElement.h:
+
 2016-07-07  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -564 +564 @@
     m_promiseTaskQueue.close();
     m_pauseAfterDetachedTaskQueue.close();
+    m_updatePlaybackControlsManagerQueue.close();
 
     m_completelyLoaded = true;
@@ -3369 +3370 @@
     }
 
-    updatePlaybackControlsManager();
+    scheduleUpdatePlaybackControlsManager();
 }
 
@@ -4014 +4015 @@
     if (!m_receivedLayoutSizeChanged) {
         m_receivedLayoutSizeChanged = true;
-        updatePlaybackControlsManager();
+        scheduleUpdatePlaybackControlsManager();
     }
 }
@@ -4862 +4863 @@
 
     if (shouldBePlaying) {
-        updatePlaybackControlsManager();
+        scheduleUpdatePlaybackControlsManager();
 
         setDisplayMode(Video);
@@ -4896 +4897 @@
         setPlaying(true);
     } else {
-        updatePlaybackControlsManager();
+        scheduleUpdatePlaybackControlsManager();
 
         if (!playerPaused)
@@ -5094 +5095 @@
     m_promiseTaskQueue.close();
     m_pauseAfterDetachedTaskQueue.close();
+    m_updatePlaybackControlsManagerQueue.close();
 
     ActiveDOMObject::contextDestroyed();
@@ -5107 +5109 @@
     m_asyncEventQueue.close();
     m_promiseTaskQueue.close();
+    m_updatePlaybackControlsManagerQueue.close();
 
     // Once an active DOM object has been stopped it can not be restarted, so we can deallocate
@@ -5957 +5960 @@
 #endif
     m_player = std::make_unique<MediaPlayer>(static_cast<MediaPlayerClient&>(*this));
-    updatePlaybackControlsManager();
+    scheduleUpdatePlaybackControlsManager();
 
 #if ENABLE(WEB_AUDIO)
@@ -7121 +7124 @@
 }
 
+void HTMLMediaElement::scheduleUpdatePlaybackControlsManager()
+{
+    if (!m_updatePlaybackControlsManagerQueue.hasPendingTasks())
+        m_updatePlaybackControlsManagerQueue.enqueueTask(std::bind(&HTMLMediaElement::updatePlaybackControlsManager, this));
+}
+
 bool HTMLMediaElement::shouldOverrideBackgroundLoadingRestriction() const
 {

trunk/Source/WebCore/html/HTMLMediaElement.h

@@ -782 +782 @@
     void pauseAfterDetachedTask();
     void updatePlaybackControlsManager();
+    void scheduleUpdatePlaybackControlsManager();
 
     void updateRenderer();
@@ -798 +799 @@
     GenericTaskQueue<Timer> m_promiseTaskQueue;
     GenericTaskQueue<Timer> m_pauseAfterDetachedTaskQueue;
+    GenericTaskQueue<Timer> m_updatePlaybackControlsManagerQueue;
     RefPtr<TimeRanges> m_playedTimeRanges;
     GenericEventQueue m_asyncEventQueue;