Changeset 202924 in webkit

Timestamp:

Jul 7, 2016, 11:57:42 AM (10 years ago)

Author:

Beth Dakin

Message:

All fullscreen videos should be able the control the controls manager
​https://bugs.webkit.org/show_bug.cgi?id=159496
-and corresponding-
rdar://problem/27009446

Reviewed by Eric Carlson.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::fullscreenModeChanged):

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::canControlControlsManager):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (1 diff)
• html/MediaElementSession.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-07  Beth Dakin  <bdakin@apple.com>
+
+        All fullscreen videos should be able the control the controls manager
+        https://bugs.webkit.org/show_bug.cgi?id=159496
+        -and corresponding-
+        rdar://problem/27009446
+
+        Reviewed by Eric Carlson.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::fullscreenModeChanged):
+        * html/MediaElementSession.cpp:
+        (WebCore::MediaElementSession::canControlControlsManager):
+
 2016-07-07  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -7149 +7149 @@
     m_videoFullscreenMode = mode;
     m_mediaSession->scheduleClientDataBufferingCheck();
-}
-
-}
-
-#endif
+    scheduleUpdatePlaybackControlsManager();
+}
+
+}
+
+#endif

trunk/Source/WebCore/html/MediaElementSession.cpp

@@ -214 +214 @@
 bool MediaElementSession::canControlControlsManager() const
 {
+    if (m_element.isFullscreen()) {
+        LOG(Media, "MediaElementSession::canControlControlsManager - returning TRUE: Is fullscreen");
+        return true;
+    }
+
     if (!m_element.hasAudio()) {
         LOG(Media, "MediaElementSession::canControlControlsManager - returning FALSE: No audio");