Changeset 202929 in webkit

Timestamp:

Jul 7, 2016, 1:53:41 PM (10 years ago)

Author:

Ryan Haddad

Message:

Unreviewed, rolling out r202905 and r202911.
​https://bugs.webkit.org/show_bug.cgi?id=159522

This test is fails on El Capitan and Sierra WK1 (Requested by
ryanhaddad on #webkit).

Reverted changesets:

"Add a test for media control dropoff"
​https://bugs.webkit.org/show_bug.cgi?id=151287
​http://trac.webkit.org/changeset/202905

"Add a test for media control dropoff"
​https://bugs.webkit.org/show_bug.cgi?id=151287
​http://trac.webkit.org/changeset/202911

Patch by Commit Queue <​commit-queue@webkit.org> on 2016-07-07

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/controls/inline-elements-dropoff-order-expected.txt (deleted)
• LayoutTests/media/controls/inline-elements-dropoff-order.html (deleted)
• LayoutTests/platform/mac-elcapitan/media/controls (deleted)
• LayoutTests/platform/mac-yosemite/media/controls (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (modified) (3 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-07-07  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r202905 and r202911.
+        https://bugs.webkit.org/show_bug.cgi?id=159522
+
+        This test is fails on El Capitan and Sierra WK1 (Requested by
+        ryanhaddad on #webkit).
+
+        Reverted changesets:
+
+        "Add a test for media control dropoff"
+        https://bugs.webkit.org/show_bug.cgi?id=151287
+        http://trac.webkit.org/changeset/202905
+
+        "Add a test for media control dropoff"
+        https://bugs.webkit.org/show_bug.cgi?id=151287
+        http://trac.webkit.org/changeset/202911
+
 2016-07-07  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-07  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r202905 and r202911.
+        https://bugs.webkit.org/show_bug.cgi?id=159522
+
+        This test is fails on El Capitan and Sierra WK1 (Requested by
+        ryanhaddad on #webkit).
+
+        Reverted changesets:
+
+        "Add a test for media control dropoff"
+        https://bugs.webkit.org/show_bug.cgi?id=151287
+        http://trac.webkit.org/changeset/202905
+
+        "Add a test for media control dropoff"
+        https://bugs.webkit.org/show_bug.cgi?id=151287
+        http://trac.webkit.org/changeset/202911
+
 2016-07-07  Antoine Quint  <graouts@apple.com>
 

trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js

@@ -2289 +2289 @@
                 name: "Show Controls",
                 object: this.showControlsButton,
-                extraProperties: ["hidden"],
+                extraProperties: ["hidden"]
             },
             {
@@ -2295 +2295 @@
                 object: this.controls.statusDisplay,
                 styleValues: ["display"],
-                extraProperties: ["textContent"],
+                extraProperties: ["textContent"]
             },
             {
                 name: "Play Button",
-                object: this.controls.playButton,
-                extraProperties: ["hidden"],
+                object: this.controls.playButton
             },
             {
                 name: "Rewind Button",
-                object: this.controls.rewindButton,
-                extraProperties: ["hidden"],
+                object: this.controls.rewindButton
             },
             {
                 name: "Timeline Box",
-                object: this.controls.timelineBox,
+                object: this.controls.timelineBox
             },
             {
                 name: "Mute Box",
-                object: this.controls.muteBox,
-                extraProperties: ["hidden"],
+                object: this.controls.muteBox
             },
             {
                 name: "Fullscreen Button",
-                object: this.controls.fullscreenButton,
-                extraProperties: ["hidden"],
+                object: this.controls.fullscreenButton
             },
             {
@@ -2331 +2327 @@
                 object: this.controls.pictureInPictureButton,
                 extraProperties: ["parentElement"],
-                extraProperties: ["hidden"],
-            },
-            {
-                name: "Caption Button",
-                object: this.controls.captionButton,
-                extraProperties: ["hidden"],
-            },
-            {
-                name: "Timeline",
-                object: this.controls.timeline,
-                extraProperties: ["hidden"],
-            },
-            {
-                name: "Current Time",
-                object: this.controls.currentTime,
-                extraProperties: ["hidden"],
-            },
-            {
-                name: "Thumbnail Track",
-                object: this.controls.thumbnailTrack,
-                extraProperties: ["hidden"],
-            },
-            {
-                name: "Time Remaining",
-                object: this.controls.remainingTime,
-                extraProperties: ["hidden"],
             },
             {
                 name: "Track Menu",
-                object: this.captionMenu,
+                object: this.captionMenu
             },
             {