Changeset 202943 in webkit

Timestamp:

Jul 7, 2016, 4:22:13 PM (10 years ago)

Author:

benjamin@webkit.org

Message:

[JSC] Array.prototype[Symbol.unscopables] should have the "includes" property
​https://bugs.webkit.org/show_bug.cgi?id=159504

Reviewed by Keith Miller.

Source/JavaScriptCore:

The property "includes" was missing.
Spec: ​https://tc39.github.io/ecma262/#sec-array.prototype-@@unscopables

• runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):

• tests/stress/unscopables.js:

LayoutTests:

• js/array-unscopables-properties-expected.txt: Added.
• js/array-unscopables-properties.html: Added.
• js/script-tests/array-unscopables-properties.js: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/array-unscopables-properties-expected.txt (added)
• LayoutTests/js/array-unscopables-properties.html (added)
• LayoutTests/js/script-tests/array-unscopables-properties.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/ArrayPrototype.cpp (modified) (1 diff)
• Source/JavaScriptCore/tests/stress/unscopables.js (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-07-07  Benjamin Poulain  <benjamin@webkit.org>
+
+        [JSC] Array.prototype[Symbol.unscopables] should have the "includes" property
+        https://bugs.webkit.org/show_bug.cgi?id=159504
+
+        Reviewed by Keith Miller.
+
+        * js/array-unscopables-properties-expected.txt: Added.
+        * js/array-unscopables-properties.html: Added.
+        * js/script-tests/array-unscopables-properties.js: Added.
+
 2016-07-07  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-07-07  Benjamin Poulain  <benjamin@webkit.org>
+
+        [JSC] Array.prototype[Symbol.unscopables] should have the "includes" property
+        https://bugs.webkit.org/show_bug.cgi?id=159504
+
+        Reviewed by Keith Miller.
+
+        The property "includes" was missing.
+        Spec: https://tc39.github.io/ecma262/#sec-array.prototype-@@unscopables
+
+        * runtime/ArrayPrototype.cpp:
+        (JSC::ArrayPrototype::finishCreation):
+        * tests/stress/unscopables.js:
+
 2016-07-07  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/runtime/ArrayPrototype.cpp

@@ -127 +127 @@
         "find",
         "findIndex",
+        "includes",
         "keys",
         "values"

trunk/Source/JavaScriptCore/tests/stress/unscopables.js

@@ -10 +10 @@
     test(typeof unscopables, "object");
     test(unscopables.__proto__, undefined);
-    test(String(Object.keys(unscopables).sort()), "copyWithin,entries,fill,find,findIndex,keys,values");
+    test(String(Object.keys(unscopables).sort()), "copyWithin,entries,fill,find,findIndex,includes,keys,values");
 }());