Changeset 202956 in webkit

Timestamp:

Jul 7, 2016, 9:10:00 PM (10 years ago)

Author:

benjamin@webkit.org

Message:

[JSC] String.prototype[Symbol.iterator] needs a name
​https://bugs.webkit.org/show_bug.cgi?id=159541

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

A man needs a name.
Spec: ​https://tc39.github.io/ecma262/#sec-string.prototype-@@iterator

• runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

LayoutTests:

• js/script-tests/string-iterator.js: Added.
• js/string-iterator-expected.txt: Added.
• js/string-iterator.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/script-tests/string-iterator.js (added)
• LayoutTests/js/string-iterator-expected.txt (added)
• LayoutTests/js/string-iterator.html (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/StringPrototype.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-07-07  Benjamin Poulain  <benjamin@webkit.org>
+
+        [JSC] String.prototype[Symbol.iterator] needs a name
+        https://bugs.webkit.org/show_bug.cgi?id=159541
+
+        Reviewed by Yusuke Suzuki.
+
+        * js/script-tests/string-iterator.js: Added.
+        * js/string-iterator-expected.txt: Added.
+        * js/string-iterator.html: Added.
+
 2016-07-07  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-07-07  Benjamin Poulain  <benjamin@webkit.org>
+
+        [JSC] String.prototype[Symbol.iterator] needs a name
+        https://bugs.webkit.org/show_bug.cgi?id=159541
+
+        Reviewed by Yusuke Suzuki.
+
+        A man needs a name.
+        Spec: https://tc39.github.io/ecma262/#sec-string.prototype-@@iterator
+
+        * runtime/StringPrototype.cpp:
+        (JSC::StringPrototype::finishCreation):
+
 2016-07-07  Michael Saboff  <msaboff@apple.com>
 

trunk/Source/JavaScriptCore/runtime/StringPrototype.cpp

@@ -175 +175 @@
     JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION("includes", stringProtoFuncIncludes, DontEnum, 1);
     JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION("normalize", stringProtoFuncNormalize, DontEnum, 0);
-    JSC_NATIVE_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->iteratorSymbol, stringProtoFuncIterator, DontEnum, 0);
-
     JSC_NATIVE_INTRINSIC_FUNCTION_WITHOUT_TRANSITION(vm.propertyNames->builtinNames().charCodeAtPrivateName(), stringProtoFuncCharCodeAt, DontEnum, 1, CharCodeAtIntrinsic);
+
+    JSFunction* iteratorFunction = JSFunction::create(vm, globalObject, 0, ASCIILiteral("[Symbol.iterator]"), stringProtoFuncIterator, NoIntrinsic);
+    putDirectWithoutTransition(vm, vm.propertyNames->iteratorSymbol, iteratorFunction, DontEnum);
 
     // The constructor will be added later, after StringConstructor has been built