Changeset 202957 in webkit

Timestamp:

Jul 7, 2016, 10:12:14 PM (10 years ago)

Author:

Beth Dakin

Message:

API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
​https://bugs.webkit.org/show_bug.cgi?id=159532
-and corresponding-
rdar://problem/27177179

Reviewed by Tim Horton.

Source/WebKit/mac:

• WebView/WebView.mm:

(-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
(-[WebView forceRequestCandidatesForTesting]):
(-[WebView shouldRequestCandidates]):

• WebView/WebViewPrivate.h:

Tools:

• TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:

(-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):

Location:

trunk

Files:

• Source/WebKit/mac/ChangeLog (modified) (1 diff)
• Source/WebKit/mac/WebView/WebView.mm (modified) (1 diff)
• Source/WebKit/mac/WebView/WebViewPrivate.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm (modified) (1 diff)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2016-07-07  Beth Dakin  <bdakin@apple.com>
+
+        API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
+        https://bugs.webkit.org/show_bug.cgi?id=159532
+        -and corresponding-
+        rdar://problem/27177179
+
+        Reviewed by Tim Horton.
+
+        * WebView/WebView.mm:
+        (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
+        (-[WebView forceRequestCandidatesForTesting]):
+        (-[WebView shouldRequestCandidates]):
+        * WebView/WebViewPrivate.h:
+
 2016-07-07  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebKit/mac/WebView/WebView.mm

@@ -6724 +6724 @@
 }
 
+- (void)forceRequestCandidatesForTesting
+{
+}
+
 - (BOOL)shouldRequestCandidates
 {

trunk/Source/WebKit/mac/WebView/WebViewPrivate.h

@@ -1070 +1070 @@
 @interface WebView (WebShowCandidates)
 - (void)showCandidates:(NSArray *)candidates forString:(NSString *)string inRect:(NSRect)rectOfTypedString forSelectedRange:(NSRange)range view:(NSView *)view completionHandler:(void (^)(NSTextCheckingResult *acceptedCandidate))completionBlock;
+- (void)forceRequestCandidatesForTesting;
 @end
 

trunk/Tools/ChangeLog

@@ +1 @@
+2016-07-07  Beth Dakin  <bdakin@apple.com>
+
+        API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
+        https://bugs.webkit.org/show_bug.cgi?id=159532
+        -and corresponding-
+        rdar://problem/27177179
+
+        Reviewed by Tim Horton.
+
+        * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
+        (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
+
 2016-07-07  Andy Estes  <aestes@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm

@@ -63 +63 @@
 - (void)webView:(WebView *)sender didFinishLoadForFrame:(WebFrame *)frame
 {
+    [sender forceRequestCandidatesForTesting];
     didFinishLoad = true;
 }