Changeset 203210 in webkit

Timestamp:

Jul 13, 2016, 8:43:07 PM (10 years ago)

Author:

Chris Dumez

Message:

Drop unnecessary check from ContainerNode::removeChild()
​https://bugs.webkit.org/show_bug.cgi?id=159747

Reviewed by Andreas Kling.

Drop unnecessary check from ContainerNode::removeChild() to make sure that
the parent of the node being removed is |this|. We already do this check
a few lines above. The only thing that happens in between is the ref'ing
of the node, which does not cause any JS execution.

This check was introduced in r55783 because there used to be a call to
document()->removeFocusedNodeOfSubtree(child.get());
between the two checks. However, this call has been removed since then
and the extra parentNode() check was left in.

• dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild): Deleted.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/ContainerNode.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-13  Chris Dumez  <cdumez@apple.com>
+
+        Drop unnecessary check from ContainerNode::removeChild()
+        https://bugs.webkit.org/show_bug.cgi?id=159747
+
+        Reviewed by Andreas Kling.
+
+        Drop unnecessary check from ContainerNode::removeChild() to make sure that
+        the parent of the node being removed is |this|. We already do this check
+        a few lines above. The only thing that happens in between is the ref'ing
+        of the node, which does not cause any JS execution.
+
+        This check was introduced in r55783 because there used to be a call to
+        document()->removeFocusedNodeOfSubtree(child.get());
+        between the two checks. However, this call has been removed since then
+        and the extra parentNode() check was left in.
+
+        * dom/ContainerNode.cpp:
+        (WebCore::ContainerNode::removeChild): Deleted.
+
 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebCore/dom/ContainerNode.cpp

@@ -525 +525 @@
     Ref<Node> child(oldChild);
 
-    // Events fired when blurring currently focused node might have moved this
-    // child into a different parent.
-    if (child->parentNode() != this) {
-        ec = NOT_FOUND_ERR;
-        return false;
-    }
-
     willRemoveChild(*this, child);