Changeset 203317 in webkit

Timestamp:

Jul 15, 2016, 6:43:53 PM (10 years ago)

Author:

Simon Fraser

Message:

Repaints rects drawn incorrectly when inspecting a WebView on a Retina display
​https://bugs.webkit.org/show_bug.cgi?id=159824
rdar://problem/27376305

Reviewed by Brian Burg.

InspectorOverlayPage.js set up the canvases with a deviceScaleFactor passed into
reset(), which comes from the overlay's m_page.deviceScaleFactor(). However, updatePaintRects()
used window.devicePixelRatio which was always 1.

Fix by setting the deviceScaleFactor on the m_overlayPage.

• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorOverlay.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-15  Simon Fraser  <simon.fraser@apple.com>
+
+        Repaints rects drawn incorrectly when inspecting a WebView on a Retina display
+        https://bugs.webkit.org/show_bug.cgi?id=159824
+        rdar://problem/27376305
+
+        Reviewed by Brian Burg.
+
+        InspectorOverlayPage.js set up the canvases with a deviceScaleFactor passed into
+        reset(), which comes from the overlay's m_page.deviceScaleFactor(). However, updatePaintRects()
+        used window.devicePixelRatio which was always 1.
+
+        Fix by setting the deviceScaleFactor on the m_overlayPage.
+
+        * inspector/InspectorOverlay.cpp:
+        (WebCore::InspectorOverlay::overlayPage):
+
 2016-07-15  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/inspector/InspectorOverlay.cpp

@@ -868 +868 @@
     fillWithEmptyClients(pageConfiguration);
     m_overlayPage = std::make_unique<Page>(WTFMove(pageConfiguration));
+    m_overlayPage->setDeviceScaleFactor(m_page.deviceScaleFactor());
 
     Settings& settings = m_page.settings();