Changeset 203321 in webkit

Timestamp:

Jul 15, 2016, 9:17:21 PM (10 years ago)

Author:

benjamin@webkit.org

Message:

[mac] LayoutTest fast/css/ancestor-of-hovered-element-detached.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=159173

Reviewed by Alexey Proskuryakov.

The test ancestor-of-hovered-element-detached.html is not reliably
covering r202324.

In the case of that test, the first style update is done with
the flag TeardownType::KeepHoverAndActive. This keeps the ":hover" state
set despite the subtree losing their renderer.
This looks like a serious issue that should be tested separately.

• fast/css/ancestor-of-hovered-element-removed.html:

The :hover update timer is actually a zero timer.
It is reasonable to expect a full update after one frame update.

• fast/css/ancestor-of-hovered-element-detached-expected.txt: Removed.
• fast/css/ancestor-of-hovered-element-detached.html: Removed.
• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/css/ancestor-of-hovered-element-detached-expected.txt (deleted)
• fast/css/ancestor-of-hovered-element-detached.html (deleted)
• fast/css/ancestor-of-hovered-element-removed.html (modified) (1 diff)
• platform/ios-simulator/TestExpectations (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-07-15  Benjamin Poulain  <benjamin@webkit.org>
+
+        [mac] LayoutTest fast/css/ancestor-of-hovered-element-detached.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=159173
+
+        Reviewed by Alexey Proskuryakov.
+
+        The test ancestor-of-hovered-element-detached.html is not reliably
+        covering r202324.
+
+        In the case of that test, the first style update is done with
+        the flag TeardownType::KeepHoverAndActive. This keeps the ":hover" state
+        set despite the subtree losing their renderer.
+        This looks like a serious issue that should be tested separately.
+
+        * fast/css/ancestor-of-hovered-element-removed.html:
+        The :hover update timer is actually a zero timer.
+        It is reasonable to expect a full update after one frame update.
+
+        * fast/css/ancestor-of-hovered-element-detached-expected.txt: Removed.
+        * fast/css/ancestor-of-hovered-element-detached.html: Removed.
+        * platform/ios-simulator/TestExpectations:
+        * platform/mac/TestExpectations:
+
 2016-07-15  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/LayoutTests/fast/css/ancestor-of-hovered-element-removed.html

@@ -94 +94 @@
         shouldBe('elementsMatchingHoverSelector()', '["html", "body", "prime-ancestor", "interceptor"]');
         finishJSTest();
-    }, 125);
+    }, 17);
     </script>
     <script src="../../resources/js-test-post.js"></script>

trunk/LayoutTests/platform/ios-simulator/TestExpectations

@@ -1413 +1413 @@
 fast/css-generated-content/table-parts-before-and-after.html [ Failure ]
 fast/css/absolute-child-with-percent-height-inside-relative-parent.html [ Failure ]
-fast/css/ancestor-of-hovered-element-detached.html [ Failure ]
 fast/css/ancestor-of-hovered-element-removed.html [ Failure ]
 fast/css/background-image-with-baseurl.html [ Failure ]

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1450 +1450 @@
 webkit.org/b/158500 storage/indexeddb/database-close-private.html [ Pass Failure ]
 
-webkit.org/b/159173 fast/css/ancestor-of-hovered-element-detached.html [ Pass Failure ]
-
 webkit.org/b/158640 imported/blink/storage/indexeddb/blob-valid-after-deletion.html [ Pass Failure ]