Changeset 20333 in webkit

Timestamp:

Mar 19, 2007, 5:30:49 PM (18 years ago)

Author:

adele

Message:

LayoutTests:

Reviewed by Beth.

Test for ​http://bugs.webkit.org/show_bug.cgi?id=13087
<rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)

• fast/forms/radio_checked_name-expected.txt: Added.
• fast/forms/radio_checked_name.html: Added.

WebCore:

Reviewed by Beth.

Fix for ​http://bugs.webkit.org/show_bug.cgi?id=13087
<rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)

Test: fast/forms/radio_checked_name.html

We were matching a WinIE quirk that does not allow a user to check and uncheck an unnamed radio button. But they still
allow the checked attribute to be set in html, and changed in javascript. So this change matches that behavior.

• html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::parseMappedAttribute): We no longer need a special call to setChecked when parsing the name attribute, since we setChecked will now work with unnamed radio buttons. (WebCore::HTMLInputElement::preDispatchEventHandler): Added comment. (WebCore::HTMLInputElement::setChecked): Don't check for the unnamed radio button case here. (WebCore::HTMLInputElement::postDispatchEventHandler): Don't call setChecked for unnamed radio buttons. (WebCore::HTMLInputElement::defaultEventHandler): ditto.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/radio_checked_name-expected.txt (added)
• LayoutTests/fast/forms/radio_checked_name.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLInputElement.cpp (modified) (5 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-03-19  Adele Peterson  <adele@apple.com>
+
+        Reviewed by Beth.
+
+        Test for http://bugs.webkit.org/show_bug.cgi?id=13087
+        <rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)
+
+        * fast/forms/radio_checked_name-expected.txt: Added.
+        * fast/forms/radio_checked_name.html: Added.
+
 2007-03-19  Justin Garcia  <justin.garcia@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-03-19  Adele Peterson  <adele@apple.com>
+
+        Reviewed by Beth.
+
+        Fix for http://bugs.webkit.org/show_bug.cgi?id=13087
+        <rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)
+
+        Test: fast/forms/radio_checked_name.html
+
+        We were matching a WinIE quirk that does not allow a user to check and uncheck an unnamed radio button.  But they still
+        allow the checked attribute to be set in html, and changed in javascript.  So this change matches that behavior.
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::parseMappedAttribute): We no longer need a special call to setChecked when parsing the name
+         attribute, since we setChecked will now work with unnamed radio buttons.
+        (WebCore::HTMLInputElement::preDispatchEventHandler): Added comment.
+        (WebCore::HTMLInputElement::setChecked): Don't check for the unnamed radio button case here.
+        (WebCore::HTMLInputElement::postDispatchEventHandler): Don't call setChecked for unnamed radio buttons.
+        (WebCore::HTMLInputElement::defaultEventHandler): ditto.
+
 2007-03-19  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/html/HTMLInputElement.cpp

@@ -585 +585 @@
         
         if (inputType() == RADIO) {
-            // In case we parsed the checked attribute first, call setChecked if the element is checked by default.
-            if (m_useDefaultChecked)
-                setChecked(m_defaultChecked);
             // Add the button to its new group.
             if (checked())
@@ -880 +877 @@
 void HTMLInputElement::setChecked(bool nowChecked, bool sendChangeEvent)
 {
-    // We mimic WinIE and don't allow unnamed radio buttons to be checked.
-    if (checked() == nowChecked || (inputType() == RADIO && name().isEmpty()))
+    if (checked() == nowChecked)
         return;
 
@@ -1060 +1056 @@
             // For radio buttons, store the current selected radio object.
             if (name().isEmpty() || checked())
-                return 0; // Unnamed radio buttons dont get checked. Checked buttons just stay checked.
+                return 0; // Match WinIE and don't allow unnamed radio buttons to be checked.
+                          // Checked buttons just stay checked.
                           // FIXME: Need to learn to work without a form.
 
@@ -1097 +1094 @@
                 // Make sure it is still a radio button and only do the restoration if it still
                 // belongs to our group.
-                if (input->form() == form() && input->inputType() == RADIO && input->name() == name()) {
+
+                // Match WinIE and don't allow unnamed radio buttons to be checked.
+                if (input->form() == form() && input->inputType() == RADIO && !name().isEmpty() && input->name() == name()) {
                     // Ok, the old radio button is still in our form and in our group and is still a 
                     // radio button, so it's safe to restore selection to it.
@@ -1253 +1252 @@
                         break;
                     if (n->hasTagName(inputTag)) {
+                        // Match WinIE and don't allow unnamed radio buttons to be checked.
                         HTMLInputElement* inputElt = static_cast<HTMLInputElement*>(n);
-                        if (inputElt->inputType() == RADIO && inputElt->name() == name() &&
-                            inputElt->isFocusable()) {
+                        if (inputElt->inputType() == RADIO && !name().isEmpty() && inputElt->name() == name() && inputElt->isFocusable()) {
                             inputElt->setChecked(true);
                             document()->setFocusedNode(inputElt);