⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 203438 in webkit


Ignore:
Timestamp:
Jul 19, 2016, 6:27:24 PM (10 years ago)
Author:
Chris Dumez
Message:

Drop SVGElement.xmlbase attribute
​https://bugs.webkit.org/show_bug.cgi?id=159926

Reviewed by Benjamin Poulain.

Source/WebCore:

Drop SVGElement.xmlbase attribute as it is no longer part of the
specification:

Both Firefox and Chrome have already dropped support for
SVGElement.xmlbase.

Chrome's intent to remove:
​https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TfwMq4d25hk/C-v_iC_wKfAJ

Test: svg/dom/SVGElement-xmlbase.html

  • svg/SVGElement.cpp:

(WebCore::SVGElement::removedFrom): Deleted.

  • svg/SVGElement.h:
  • svg/SVGElement.idl:

LayoutTests:

  • svg/dom/SVGElement-xmlbase-expected.txt: Added.
  • svg/dom/SVGElement-xmlbase.html: Added.

Check that SVGElement.xmlbase does not exist.

  • svg/dom/svg-element-attribute-js-null-expected.txt:
  • svg/dom/svg-element-attribute-js-null.xhtml:

Drop obsolete testing for SVGElement.xmlbase.

Location:
trunk
Files:
2 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r203437 r203438  
     12016-07-19  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop SVGElement.xmlbase attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=159926
     5
     6        Reviewed by Benjamin Poulain.
     7
     8        * svg/dom/SVGElement-xmlbase-expected.txt: Added.
     9        * svg/dom/SVGElement-xmlbase.html: Added.
     10        Check that SVGElement.xmlbase does not exist.
     11
     12        * svg/dom/svg-element-attribute-js-null-expected.txt:
     13        * svg/dom/svg-element-attribute-js-null.xhtml:
     14        Drop obsolete testing for SVGElement.xmlbase.
     15
    1162016-07-19  Chris Dumez  <cdumez@apple.com>
    217

  • trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt

    r195700 r203438  
    22
    33TEST SUCCEEDED: The value was the string 'null'. [tested SVGElement.id]
    4 TEST SUCCEEDED: The value was the empty string. [tested SVGElement.xmlbase]
    54
    65TEST SUCCEEDED: The value was the string '0'. [tested SVGAngle.valueAsString]

  • trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml

    r195700 r203438  
    5454                    attributes: [
    5555                        {name: 'id', expectedNull: 'null'},
    56                         {name: 'xmlbase', expectedNull: ''}
    5756                    ]
    5857                },

  • trunk/Source/WebCore/ChangeLog

    r203437 r203438  
     12016-07-19  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop SVGElement.xmlbase attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=159926
     5
     6        Reviewed by Benjamin Poulain.
     7
     8        Drop SVGElement.xmlbase attribute as it is no longer part of the
     9        specification:
     10        - https://www.w3.org/TR/SVG2/types.html#InterfaceSVGElement
     11
     12        Both Firefox and Chrome have already dropped support for
     13        SVGElement.xmlbase.
     14
     15        Chrome's intent to remove:
     16        https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/TfwMq4d25hk/C-v_iC_wKfAJ
     17
     18        Test: svg/dom/SVGElement-xmlbase.html
     19
     20        * svg/SVGElement.cpp:
     21        (WebCore::SVGElement::removedFrom): Deleted.
     22        * svg/SVGElement.h:
     23        * svg/SVGElement.idl:
     24
    1252016-07-19  Chris Dumez  <cdumez@apple.com>
    226

  • trunk/Source/WebCore/svg/SVGElement.cpp

    r203324 r203438  
    366366{
    367367    return DOMImplementation::hasFeature(feature, version);
    368 }
    369 
    370 String SVGElement::xmlbase() const
    371 {
    372     return attributeWithoutSynchronization(XMLNames::baseAttr);
    373 }
    374 
    375 void SVGElement::setXmlbase(const String& value, ExceptionCode&)
    376 {
    377     setAttributeWithoutSynchronization(XMLNames::baseAttr, value);
    378368}
    379369

  • trunk/Source/WebCore/svg/SVGElement.h

    r201757 r203438  
    5454    bool isOutermostSVGSVGElement() const;
    5555
    56     String xmlbase() const;
    57     void setXmlbase(const String&, ExceptionCode&);
    58 
    5956    SVGSVGElement* ownerSVGElement() const;
    6057    SVGElement* viewportElement() const;

  • trunk/Source/WebCore/svg/SVGElement.idl

    r202539 r203438  
    2424    JSGenerateToNativeObject,
    2525] interface SVGElement : Element {
    26     // FIXME: the xmlbase attribute is no longer part of SVG2 and Chrome already dropped it.
    27     // FIXME: This should not use [TreatNullAs=LegacyNullString].
    28     [TreatNullAs=LegacyNullString, SetterRaisesException] attribute DOMString xmlbase;
    29 
    3026    readonly attribute SVGSVGElement ownerSVGElement;
    3127    readonly attribute SVGElement viewportElement;
Note: See TracChangeset for help on using the changeset viewer.