Changeset 203444 in webkit

Timestamp:

Jul 19, 2016, 10:13:06 PM (10 years ago)

Author:

Chris Dumez

Message:

Fix null handling of SVGScriptElement.type attribute
​https://bugs.webkit.org/show_bug.cgi?id=159927

Reviewed by Benjamin Poulain.

Source/WebCore:

Fix null handling of SVGScriptElement.type attribute:

• ​https://www.w3.org/TR/SVG2/interact.html#InterfaceSVGScriptElement

We were treating null as the null String which would end up removing
the 'type' content attribute. However, we should treat null as the
String "null".

Firefox and Chrome match the specification.

No new tests, updated existing test.

• svg/SVGScriptElement.idl:

LayoutTests:

Rebaseline existing test to reflect the behavior change.

• svg/dom/svg-element-attribute-js-null-expected.txt:
• svg/dom/svg-element-attribute-js-null.xhtml:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt (modified) (1 diff)
• LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGScriptElement.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-07-19  Chris Dumez  <cdumez@apple.com>
+
+        Fix null handling of SVGScriptElement.type attribute
+        https://bugs.webkit.org/show_bug.cgi?id=159927
+
+        Reviewed by Benjamin Poulain.
+
+        Rebaseline existing test to reflect the behavior change.
+
+        * svg/dom/svg-element-attribute-js-null-expected.txt:
+        * svg/dom/svg-element-attribute-js-null.xhtml:
+
 2016-07-19  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/svg/dom/svg-element-attribute-js-null-expected.txt

@@ -7 +7 @@
 TEST SUCCEEDED: The value was the string '0'. [tested SVGLength.valueAsString]
 
-TEST SUCCEEDED: The value was the empty string. [tested SVGScriptElement.type]
+TEST SUCCEEDED: The value was the string 'null'. [tested SVGScriptElement.type]
 
 

trunk/LayoutTests/svg/dom/svg-element-attribute-js-null.xhtml

@@ -74 +74 @@
                     elementToUse: document.createElementNS(svgNS, 'script'),
                     attributes: [
-                        {name: 'type', expectedNull: ''}
+                        {name: 'type', expectedNull: 'null'}
                     ]
                 }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-19  Chris Dumez  <cdumez@apple.com>
+
+        Fix null handling of SVGScriptElement.type attribute
+        https://bugs.webkit.org/show_bug.cgi?id=159927
+
+        Reviewed by Benjamin Poulain.
+
+        Fix null handling of SVGScriptElement.type attribute:
+        - https://www.w3.org/TR/SVG2/interact.html#InterfaceSVGScriptElement
+
+        We were treating null as the null String which would end up removing
+        the 'type' content attribute. However, we should treat null as the
+        String "null".
+
+        Firefox and Chrome match the specification.
+
+        No new tests, updated existing test.
+
+        * svg/SVGScriptElement.idl:
+
 2016-07-19  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/svg/SVGScriptElement.idl

@@ -25 +25 @@
 
 interface SVGScriptElement : SVGElement {
-    // FIXME: This should not use [TreatNullAs=LegacyNullString].
-    [TreatNullAs=LegacyNullString, Reflect] attribute DOMString type;
+    [Reflect] attribute DOMString type;
 };