Changeset 203505 in webkit

Timestamp:

Jul 21, 2016, 9:05:16 AM (10 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK][Threaded Compositor] Overlay scrollbars shouldn't be a requirement of the threaded compositor
​https://bugs.webkit.org/show_bug.cgi?id=160020

Reviewed by Michael Catanzaro.

It has been a requirement only because we didn't really know why frame scrollbars were not rendered when using
the threaded compositor. The reason is that RenderView doesn't use layers for FrameView scrollbars by default,
unless using overlay scrollbars. When using the threaded compositor we really need layers for the FrameView
scrollbars even when not using overlay scrollbars.

• platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Stop enforcing overlay scrollbars when threaded compositor is enabled.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldCompositeOverflowControls): Always use layers for scrollbars when
threaded compositor is enabled.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/ScrollbarThemeGtk.cpp (modified) (1 diff)
• rendering/RenderLayerCompositor.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][Threaded Compositor] Overlay scrollbars shouldn't be a requirement of the threaded compositor
+        https://bugs.webkit.org/show_bug.cgi?id=160020
+
+        Reviewed by Michael Catanzaro.
+
+        It has been a requirement only because we didn't really know why frame scrollbars were not rendered when using
+        the threaded compositor. The reason is that RenderView doesn't use layers for FrameView scrollbars by default,
+        unless using overlay scrollbars. When using the threaded compositor we really need layers for the FrameView
+        scrollbars even when not using overlay scrollbars.
+
+        * platform/gtk/ScrollbarThemeGtk.cpp:
+        (WebCore::ScrollbarThemeGtk::ScrollbarThemeGtk): Stop enforcing overlay scrollbars when threaded compositor is enabled.
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::shouldCompositeOverflowControls): Always use layers for scrollbars when
+        threaded compositor is enabled.
+
 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp

@@ -58 +58 @@
 {
 #if GTK_CHECK_VERSION(3, 20, 0)
-#if USE(COORDINATED_GRAPHICS_THREADED)
-    m_usesOverlayScrollbars = true;
-#else
     m_usesOverlayScrollbars = g_strcmp0(g_getenv("GTK_OVERLAY_SCROLLING"), "0");
-#endif
 #endif
     static bool themeMonitorInitialized = false;

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -3010 +3010 @@
         return true;
 
+#if !USE(COORDINATED_GRAPHICS_THREADED)
     if (!frameView.hasOverlayScrollbars())
         return false;
+#endif
 
     return true;