Changeset 203507 in webkit

Timestamp:

Jul 21, 2016, 9:59:33 AM (10 years ago)

Author:

commit-queue@webkit.org

Message:

Web Automation: Allow JavaScript evaluation to return an InvalidElementState error
​https://bugs.webkit.org/show_bug.cgi?id=160015
<rdar://problem/27434529>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-21
Reviewed by Brian Burg.

• UIProcess/Automation/Automation.json:
• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Automation/Automation.json (modified) (1 diff)
• WebProcess/Automation/WebAutomationSessionProxy.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-07-21  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Automation: Allow JavaScript evaluation to return an InvalidElementState error
+        https://bugs.webkit.org/show_bug.cgi?id=160015
+        <rdar://problem/27434529>
+
+        Reviewed by Brian Burg.
+
+        * UIProcess/Automation/Automation.json:
+        * WebProcess/Automation/WebAutomationSessionProxy.cpp:
+        (WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):
+
 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/UIProcess/Automation/Automation.json

@@ -54 +54 @@
                 "FrameNotFound",
                 "NodeNotFound",
+                "InvalidElementState",
                 "NoJavaScriptDialog",
                 "NotImplemented",

trunk/Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.cpp

@@ -272 +272 @@
         if (exceptionName->string() == "NodeNotFound")
             errorType = Inspector::Protocol::AutomationHelpers::getEnumConstantValue(Inspector::Protocol::Automation::ErrorMessage::NodeNotFound);
+        else if (exceptionName->string() == "InvalidElementState")
+            errorType = Inspector::Protocol::AutomationHelpers::getEnumConstantValue(Inspector::Protocol::Automation::ErrorMessage::InvalidElementState);        
 
         JSValueRef messageValue = JSObjectGetProperty(context, const_cast<JSObjectRef>(exception), toJSString(ASCIILiteral("message")).get(), nullptr);