Changeset 203510 in webkit

Timestamp:

Jul 21, 2016, 10:20:44 AM (10 years ago)

Author:

Chris Dumez

Message:

Drop [TreatNullAs=EmptyString] from CanvasRenderingContext2D.globalCompositeOperation
​https://bugs.webkit.org/show_bug.cgi?id=160026

Reviewed by Sam Weinig.

Source/WebCore:

Drop [TreatNullAs=EmptyString] from CanvasRenderingContext2D.globalCompositeOperation
attribute as it does not match the specification:

• ​https://html.spec.whatwg.org/multipage/scripting.html#canvascompositing

It does not change web-exposed behavior because assigning to "" or "null"
gets ignored as those are not valid operations.

Test: fast/canvas/context-globalCompositeOperation-null.html

• html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

Add test coverage.

• fast/canvas/context-globalCompositeOperation-null-expected.txt: Added.
• fast/canvas/context-globalCompositeOperation-null.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/canvas/context-globalCompositeOperation-null-expected.txt (added)
• LayoutTests/fast/canvas/context-globalCompositeOperation-null.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/canvas/CanvasRenderingContext2D.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-07-21  Chris Dumez  <cdumez@apple.com>
+
+        Drop [TreatNullAs=EmptyString] from CanvasRenderingContext2D.globalCompositeOperation
+        https://bugs.webkit.org/show_bug.cgi?id=160026
+
+        Reviewed by Sam Weinig.
+
+        Add test coverage.
+
+        * fast/canvas/context-globalCompositeOperation-null-expected.txt: Added.
+        * fast/canvas/context-globalCompositeOperation-null.html: Added.
+
 2016-07-21  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-21  Chris Dumez  <cdumez@apple.com>
+
+        Drop [TreatNullAs=EmptyString] from CanvasRenderingContext2D.globalCompositeOperation
+        https://bugs.webkit.org/show_bug.cgi?id=160026
+
+        Reviewed by Sam Weinig.
+
+        Drop [TreatNullAs=EmptyString] from CanvasRenderingContext2D.globalCompositeOperation
+        attribute as it does not match the specification:
+        - https://html.spec.whatwg.org/multipage/scripting.html#canvascompositing
+
+        It does not change web-exposed behavior because assigning to "" or "null"
+        gets ignored as those are not valid operations.
+
+        Test: fast/canvas/context-globalCompositeOperation-null.html
+
+        * html/canvas/CanvasRenderingContext2D.idl:
+
 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl

@@ -44 +44 @@
     attribute unrestricted float globalAlpha;
 
-    // FIXME: This should not have [TreatNullAs=EmptyString].
-    [TreatNullAs=EmptyString] attribute DOMString globalCompositeOperation;
+    attribute DOMString globalCompositeOperation;
 
     [RaisesException] CanvasGradient createLinearGradient(float x0, float y0, float x1, float y1);