Changeset 203511 in webkit

Timestamp:

Jul 21, 2016, 10:54:27 AM (10 years ago)

Author:

Chris Dumez

Message:

playsInline IDL attribute has the wrong casing
​https://bugs.webkit.org/show_bug.cgi?id=160029
<rdar://problem/27474031>

Reviewed by Jon Lee.

Source/WebCore:

Fix case from video.playsinline to video.playsInline in order to match
the specification:

• ​https://html.spec.whatwg.org/multipage/embedded-content.html#the-video-element:dom-video-playsinline

It still reflects the "playsinline" content attribute though, as per
the specification:

• ​https://html.spec.whatwg.org/multipage/embedded-content.html#dom-video-playsinline

No new tests, updated existing test.

• html/HTMLVideoElement.idl:

LayoutTests:

Update test to use the correct case.

• media/video-playsinline-expected.txt:
• media/video-playsinline.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/video-playsinline-expected.txt (modified) (4 diffs)
• LayoutTests/media/video-playsinline.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLVideoElement.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2016-07-21  Chris Dumez  <cdumez@apple.com>
+
+        playsInline IDL attribute has the wrong casing
+        https://bugs.webkit.org/show_bug.cgi?id=160029
+        <rdar://problem/27474031>
+
+        Reviewed by Jon Lee.
+
+        Update test to use the correct case.
+
+        * media/video-playsinline-expected.txt:
+        * media/video-playsinline.html:
+
 2016-07-21  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/media/video-playsinline-expected.txt

@@ -1 +1 @@
 RUN(internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(true))
-RUN(video.playsinline = false)
+RUN(video.playsInline = false)
 EVENT(canplaythrough)
 RUN(video.play())
@@ -6 +6 @@
 EXPECTED (video.webkitDisplayingFullscreen == 'true') OK
 RUN(internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(true))
-RUN(video.playsinline = true)
+RUN(video.playsInline = true)
 EVENT(canplaythrough)
 RUN(video.play())
@@ -12 +12 @@
 EXPECTED (video.webkitDisplayingFullscreen == 'false') OK
 RUN(internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(false))
-RUN(video.playsinline = false)
+RUN(video.playsInline = false)
 EVENT(canplaythrough)
 RUN(video.play())
@@ -18 +18 @@
 EXPECTED (video.webkitDisplayingFullscreen == 'false') OK
 RUN(internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(false))
-RUN(video.playsinline = true)
+RUN(video.playsInline = true)
 EVENT(canplaythrough)
 RUN(video.play())

trunk/LayoutTests/media/video-playsinline.html

@@ -25 +25 @@
     video.controls = true;
     video.src = findMediaFile('video', 'content/test');
-    run('video.playsinline = ' + hasPlaysInline);
+    run('video.playsInline = ' + hasPlaysInline);
     waitForEventOnce('canplaythrough', () => {
         runWithKeyDown(() => {

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-21  Chris Dumez  <cdumez@apple.com>
+
+        playsInline IDL attribute has the wrong casing
+        https://bugs.webkit.org/show_bug.cgi?id=160029
+        <rdar://problem/27474031>
+
+        Reviewed by Jon Lee.
+
+        Fix case from video.playsinline to video.playsInline in order to match
+        the specification:
+        - https://html.spec.whatwg.org/multipage/embedded-content.html#the-video-element:dom-video-playsinline
+
+        It still reflects the "playsinline" content attribute though, as per
+        the specification:
+        - https://html.spec.whatwg.org/multipage/embedded-content.html#dom-video-playsinline
+
+        No new tests, updated existing test.
+
+        * html/HTMLVideoElement.idl:
+
 2016-07-21  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/html/HTMLVideoElement.idl

@@ -34 +34 @@
     [Reflect, URL] attribute DOMString poster;
 
-    [Reflect] attribute boolean playsinline;
+    [Reflect=playsinline] attribute boolean playsInline;
     readonly attribute boolean webkitSupportsFullscreen;
     readonly attribute boolean webkitDisplayingFullscreen;