Changeset 203514 in webkit

Timestamp:

Jul 21, 2016, 11:20:20 AM (10 years ago)

Author:

Alan Bujtas

Message:

Do not keep invalid IOSurface in ImageBufferData.
​https://bugs.webkit.org/show_bug.cgi?id=160005
<rdar://problem/27208636>

Reviewed by Simon Fraser.

When we fail to initialize the IOSurface for the accelerated context, we switch over to
the non-accelerated code path. Since ImageBufferData::surface is used to indicate whether
the graphics context is in accelerated mode, we need to reset it when the initialization fails.

Unable to create a test case.

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cg/ImageBufferCG.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-07-21  Zalan Bujtas  <zalan@apple.com>
+
+        Do not keep invalid IOSurface in ImageBufferData.
+        https://bugs.webkit.org/show_bug.cgi?id=160005
+        <rdar://problem/27208636>
+
+        Reviewed by Simon Fraser.
+
+        When we fail to initialize the IOSurface for the accelerated context, we switch over to
+        the non-accelerated code path. Since ImageBufferData::surface is used to indicate whether
+        the graphics context is in accelerated mode, we need to reset it when the initialization fails.
+
+        Unable to create a test case.
+
+        * platform/graphics/cg/ImageBufferCG.cpp:
+        (WebCore::ImageBuffer::ImageBuffer):
+
 2016-07-21  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp

@@ -159 +159 @@
         if (cgContext)
             CGContextClearRect(cgContext.get(), FloatRect(FloatPoint(), userBounds));
+        else
+            m_data.surface = nullptr;
 #endif