⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 203528 in webkit


Ignore:
Timestamp:
Jul 21, 2016, 2:23:28 PM (10 years ago)
Author:
Chris Dumez
Message:

Fix null handling for HTMLObjectElement.border
​https://bugs.webkit.org/show_bug.cgi?id=160040

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/html/dom/reflection-embedded-expected.txt:

Source/WebCore:

Fix null handling for HTMLObjectElement.border to match the specification:

We are supposed to treat null as the empty string.

Both Firefox and Chrome agree with the specification.

No new tests, rebaselined existing tests.

  • html/HTMLObjectElement.idl:

LayoutTests:

Update existing test to reflect the behavior change.

  • fast/dom/element-attribute-js-null-expected.txt:
  • fast/dom/element-attribute-js-null.html:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r203527 r203528  
     12016-07-21  Chris Dumez  <cdumez@apple.com>
     2
     3        Fix null handling for HTMLObjectElement.border
     4        https://bugs.webkit.org/show_bug.cgi?id=160040
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Update existing test to reflect the behavior change.
     9
     10        * fast/dom/element-attribute-js-null-expected.txt:
     11        * fast/dom/element-attribute-js-null.html:
     12
    1132016-07-21  Chris Dumez  <cdumez@apple.com>
    214

  • trunk/LayoutTests/fast/dom/element-attribute-js-null-expected.txt

    r203527 r203528  
    148148TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.align]
    149149TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.archive]
    150 TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.border]
     150TEST SUCCEEDED: The value was the empty string. [tested HTMLObjectElement.border]
    151151TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.codeBase]
    152152TEST SUCCEEDED: The value was the string 'null'. [tested HTMLObjectElement.codeType]

  • trunk/LayoutTests/fast/dom/element-attribute-js-null.html

    r203527 r203528  
    384384                        {name: 'align', expectedNull: 'null'},
    385385                        {name: 'archive', expectedNull: 'null'},
    386                         {name: 'border', expectedNull: 'null'},
     386                        {name: 'border', expectedNull: ''},
    387387                        {name: 'codeBase', expectedNull: 'null'},
    388388                        {name: 'codeType', expectedNull: 'null'},

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r203527 r203528  
     12016-07-21  Chris Dumez  <cdumez@apple.com>
     2
     3        Fix null handling for HTMLObjectElement.border
     4        https://bugs.webkit.org/show_bug.cgi?id=160040
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Rebaseline W3C test now that more checks are passing.
     9
     10        * web-platform-tests/html/dom/reflection-embedded-expected.txt:
     11
    1122016-07-21  Chris Dumez  <cdumez@apple.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt

    r203524 r203528  
    65916591PASS object.border: IDL set to "\0" followed by IDL get
    65926592PASS object.border: IDL set to null should not throw
    6593 FAIL object.border: IDL set to null followed by getAttribute() assert_equals: expected "" but got "null"
    6594 FAIL object.border: IDL set to null followed by IDL get assert_equals: expected "" but got "null"
     6593PASS object.border: IDL set to null followed by getAttribute()
     6594PASS object.border: IDL set to null followed by IDL get
    65956595PASS object.border: IDL set to object "test-toString" should not throw
    65966596PASS object.border: IDL set to object "test-toString" followed by getAttribute()

  • trunk/LayoutTests/platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt

    r203524 r203528  
    65916591PASS object.border: IDL set to "\0" followed by IDL get
    65926592PASS object.border: IDL set to null should not throw
    6593 FAIL object.border: IDL set to null followed by getAttribute() assert_equals: expected "" but got "null"
    6594 FAIL object.border: IDL set to null followed by IDL get assert_equals: expected "" but got "null"
     6593PASS object.border: IDL set to null followed by getAttribute()
     6594PASS object.border: IDL set to null followed by IDL get
    65956595PASS object.border: IDL set to object "test-toString" should not throw
    65966596PASS object.border: IDL set to object "test-toString" followed by getAttribute()

  • trunk/Source/WebCore/ChangeLog

    r203527 r203528  
     12016-07-21  Chris Dumez  <cdumez@apple.com>
     2
     3        Fix null handling for HTMLObjectElement.border
     4        https://bugs.webkit.org/show_bug.cgi?id=160040
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Fix null handling for HTMLObjectElement.border to match the specification:
     9        - https://html.spec.whatwg.org/#HTMLObjectElement-partial
     10
     11        We are supposed to treat null as the empty string.
     12
     13        Both Firefox and Chrome agree with the specification.
     14
     15        No new tests, rebaselined existing tests.
     16
     17        * html/HTMLObjectElement.idl:
     18
    1192016-07-21  Chris Dumez  <cdumez@apple.com>
    220

  • trunk/Source/WebCore/html/HTMLObjectElement.idl

    r197156 r203528  
    2828    [Reflect] attribute DOMString align;
    2929    [Reflect] attribute DOMString archive;
    30     [Reflect] attribute DOMString border;
     30    [Reflect, TreatNullAs=EmptyString] attribute DOMString border;
    3131    [Reflect] attribute DOMString codeBase;
    3232    [Reflect] attribute DOMString codeType;
Note: See TracChangeset for help on using the changeset viewer.