⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 204113 in webkit


Ignore:
Timestamp:
Aug 3, 2016, 10:09:18 PM (10 years ago)
Author:
Chris Dumez
Message:

Drop legacy Document.defaultCharset attribute
​https://bugs.webkit.org/show_bug.cgi?id=160536

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

  • web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop legacy Document.defaultCharset attribute.

It is no longer in the specification:

Firefox and Chrome have already dropped it.

No new tests, rebaselined existing test.

  • bindings/objc/DOMDocument.mm:

(-[DOMDocument defaultCharset]):

  • dom/Document.cpp:

(WebCore::Document::defaultCharsetForBindings):

  • dom/Document.h:
  • dom/Document.idl:

LayoutTests:

  • fast/dom/Document/document-charset-expected.txt:
  • fast/dom/Document/document-charset.html:

Drop defaultCharset checks.

  • fast/frames/detached-frame-document-defaultCharset-expected.txt: Removed.
  • fast/frames/detached-frame-document-defaultCharset.html: Removed.

Drop test that is no longer useful now that we dropped defaultCharset.

Location:
trunk
Files:
2 deleted
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r204109 r204113  
     12016-08-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop legacy Document.defaultCharset attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=160536
     5
     6        Reviewed by Alex Christensen.
     7
     8        * fast/dom/Document/document-charset-expected.txt:
     9        * fast/dom/Document/document-charset.html:
     10        Drop defaultCharset checks.
     11
     12        * fast/frames/detached-frame-document-defaultCharset-expected.txt: Removed.
     13        * fast/frames/detached-frame-document-defaultCharset.html: Removed.
     14        Drop test that is no longer useful now that we dropped defaultCharset.
     15
    1162016-08-03  Ryan Haddad  <ryanhaddad@apple.com>
    217

  • trunk/LayoutTests/fast/dom/Document/document-charset-expected.txt

    r195521 r204113  
    22
    33 document.charset: KOI8-R
    4 
    5  document.defaultCharset: defined
    64
    75 document.characterSet: KOI8-R
    … …  
    1311 document.charset: KOI8-R
    1412
    15  document.defaultCharset: defined
    16 
    1713 document.characterSet: KOI8-R
    1814
    … …  
    2319 document.charset: KOI8-R
    2420
    25  document.defaultCharset: defined
    26 
    2721 document.characterSet: KOI8-R
    2822

  • trunk/LayoutTests/fast/dom/Document/document-charset.html

    r195521 r204113  
    1212document.write("<p>Initial</p>");
    1313document.write("<p>&nbsp;document.charset: " + document.charset + "</p>");
    14 document.write("<p>&nbsp;document.defaultCharset: " + (document.defaultCharset ? "defined" : "undefined") + "</p>");
    1514document.write("<p>&nbsp;document.characterSet: " + document.characterSet + "</p>");
    1615document.write("<p>&nbsp;document.inputEncoding: " + document.inputEncoding + "</p>");
    … …  
    2019    document.charset = "utf-8";
    2120    document.write("<p>&nbsp;document.charset: " + document.charset + "</p>");
    22     document.write("<p>&nbsp;document.defaultCharset: " + (document.defaultCharset ? "defined" : "undefined") + "</p>");
    2321    document.write("<p>&nbsp;document.characterSet: " + document.characterSet + "</p>");
    2422    document.write("<p>&nbsp;document.inputEncoding: " + document.inputEncoding + "</p>");
    … …  
    3129    document.characterSet = "utf-8";
    3230    document.write("<p>&nbsp;document.charset: " + document.charset + "</p>");
    33     document.write("<p>&nbsp;document.defaultCharset: " + (document.defaultCharset ? "defined" : "undefined") + "</p>");
    3431    document.write("<p>&nbsp;document.characterSet: " + document.characterSet + "</p>");
    3532    document.write("<p>&nbsp;document.inputEncoding: " + document.inputEncoding + "</p>");

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r204090 r204113  
     12016-08-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop legacy Document.defaultCharset attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=160536
     5
     6        Reviewed by Alex Christensen.
     7
     8        Rebaseline W3C test now that one more check is passing.
     9
     10        * web-platform-tests/dom/historical-expected.txt:
     11
    1122016-08-03  Chris Dumez  <cdumez@apple.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt

    r202471 r204113  
    3333PASS Historical DOM features must be removed: normalizeDocument
    3434PASS Historical DOM features must be removed: renameNode
    35 FAIL Historical DOM features must be removed: defaultCharset assert_equals: expected (undefined) undefined but got (string) "ISO-8859-1"
     35PASS Historical DOM features must be removed: defaultCharset
    3636PASS Historical DOM features must be removed: height
    3737PASS Historical DOM features must be removed: width

  • trunk/Source/WebCore/ChangeLog

    r204108 r204113  
     12016-08-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop legacy Document.defaultCharset attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=160536
     5
     6        Reviewed by Alex Christensen.
     7
     8        Drop legacy Document.defaultCharset attribute.
     9
     10        It is no longer in the specification:
     11        - https://dom.spec.whatwg.org/#interface-document
     12
     13        Firefox and Chrome have already dropped it.
     14
     15        No new tests, rebaselined existing test.
     16
     17        * bindings/objc/DOMDocument.mm:
     18        (-[DOMDocument defaultCharset]):
     19        * dom/Document.cpp:
     20        (WebCore::Document::defaultCharsetForBindings):
     21        * dom/Document.h:
     22        * dom/Document.idl:
     23
    1242016-08-03  Anders Carlsson  <andersca@apple.com>
    225

  • trunk/Source/WebCore/bindings/objc/DOMDocument.mm

    r204083 r204113  
    320320{
    321321    WebCore::JSMainThreadNullState state;
    322     return IMPL->defaultCharset();
     322    return IMPL->defaultCharsetForBindings();
    323323}
    324324

  • trunk/Source/WebCore/dom/Document.cpp

    r204061 r204113  
    13411341}
    13421342
    1343 String Document::defaultCharset() const
     1343String Document::defaultCharsetForBindings() const
    13441344{
    13451345    if (Settings* settings = this->settings())

  • trunk/Source/WebCore/dom/Document.h

    r203971 r204113  
    418418    String readyState() const;
    419419
    420     String defaultCharset() const;
     420    String defaultCharsetForBindings() const;
    421421
    422422    String charset() const { return Document::encoding(); }

  • trunk/Source/WebCore/dom/Document.idl

    r204108 r204113  
    194194    [ImplementedAs=characterSetWithUTF8Fallback] readonly attribute DOMString charset;
    195195#endif
    196     readonly attribute DOMString defaultCharset;
    197196    readonly attribute DOMString readyState;
    198197
Note: See TracChangeset for help on using the changeset viewer.