⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 204114 in webkit


Ignore:
Timestamp:
Aug 3, 2016, 10:11:26 PM (10 years ago)
Author:
Chris Dumez
Message:

Drop DocumentType.internalSubset attribute
​https://bugs.webkit.org/show_bug.cgi?id=160530

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

  • web-platform-tests/dom/historical-expected.txt:

Source/JavaScriptCore:

Drop DocumentType.internalSubset attribute.

  • inspector/protocol/DOM.json:

Source/WebCore:

Drop DocumentType.internalSubset attribute.

It is no longer in the DOM specification:

Other browsers have already dropped it. In WebKit, it was always null
anyway.

No new tests, rebaselined existing test.

  • bindings/objc/DOMDocumentType.mm:

(-[DOMDocumentType internalSubset]):

  • dom/DocumentType.h:
  • dom/DocumentType.idl:
  • dom/Node.cpp:

(WebCore::Node::isEqualNode): Deleted.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendDocumentType): Deleted.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode): Deleted.

Source/WebInspectorUI:

Drop DocumentType.internalSubset attribute.

  • UserInterface/Models/DOMNode.js:

(WebInspector.DOMNode): Deleted.

  • UserInterface/Models/DOMSearchMatchObject.js:

(WebInspector.DOMSearchMatchObject.titleForDOMNode): Deleted.

  • UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._nodeTitleInfo): Deleted.

Location:
trunk
Files:
15 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r204113 r204114  
     12016-08-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop DocumentType.internalSubset attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=160530
     5
     6        Reviewed by Alex Christensen.
     7
     8        Rebaseline W3C test now that one more check is passing.
     9
     10        * web-platform-tests/dom/historical-expected.txt:
     11
    1122016-08-03  Chris Dumez  <cdumez@apple.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/dom/historical-expected.txt

    r204113 r204114  
    4343PASS DocumentType member must be nuked: entities
    4444PASS DocumentType member must be nuked: notations
    45 FAIL DocumentType member must be nuked: internalSubset assert_equals: expected (undefined) undefined but got (object) null
     45PASS DocumentType member must be nuked: internalSubset
    4646PASS Text member must be nuked: isElementContentWhitespace
    4747FAIL Text member must be nuked: replaceWholeText assert_equals: expected (undefined) undefined but got (function) function "function replaceWholeText() {

  • trunk/Source/JavaScriptCore/ChangeLog

    r204112 r204114  
     12016-08-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop DocumentType.internalSubset attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=160530
     5
     6        Reviewed by Alex Christensen.
     7
     8        Drop DocumentType.internalSubset attribute.
     9
     10        * inspector/protocol/DOM.json:
     11
    1122016-08-03  Benjamin Poulain  <bpoulain@apple.com>
    213

  • trunk/Source/JavaScriptCore/inspector/protocol/DOM.json

    r202634 r204114  
    4848                { "name": "publicId", "type": "string", "optional": true, "description": "<code>DocumentType</code>'s publicId." },
    4949                { "name": "systemId", "type": "string", "optional": true, "description": "<code>DocumentType</code>'s systemId." },
    50                 { "name": "internalSubset", "type": "string", "optional": true, "description": "<code>DocumentType</code>'s internalSubset." },
    5150                { "name": "xmlVersion", "type": "string", "optional": true, "description": "<code>Document</code>'s XML version in case of XML documents." },
    5251                { "name": "name", "type": "string", "optional": true, "description": "<code>Attr</code>'s name." },

  • trunk/Source/WebCore/ChangeLog

    r204113 r204114  
     12016-08-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop DocumentType.internalSubset attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=160530
     5
     6        Reviewed by Alex Christensen.
     7
     8        Drop DocumentType.internalSubset attribute.
     9
     10        It is no longer in the DOM specification:
     11        - https://dom.spec.whatwg.org/#documenttype
     12        - https://w3c.github.io/DOM-Parsing/#xml-serializing-a-documenttype-node
     13
     14        Other browsers have already dropped it. In WebKit, it was always null
     15        anyway.
     16
     17        No new tests, rebaselined existing test.
     18
     19        * bindings/objc/DOMDocumentType.mm:
     20        (-[DOMDocumentType internalSubset]):
     21        * dom/DocumentType.h:
     22        * dom/DocumentType.idl:
     23        * dom/Node.cpp:
     24        (WebCore::Node::isEqualNode): Deleted.
     25        * editing/MarkupAccumulator.cpp:
     26        (WebCore::MarkupAccumulator::appendDocumentType): Deleted.
     27        * inspector/InspectorDOMAgent.cpp:
     28        (WebCore::InspectorDOMAgent::buildObjectForNode): Deleted.
     29
    1302016-08-03  Chris Dumez  <cdumez@apple.com>
    231

  • trunk/Source/WebCore/bindings/objc/DOMDocumentType.mm

    r204083 r204114  
    7575{
    7676    WebCore::JSMainThreadNullState state;
    77     return IMPL->internalSubset();
     77    return IMPL->internalSubsetForBindings();
    7878}
    7979

  • trunk/Source/WebCore/dom/DocumentType.h

    r197563 r204114  
    4141    NamedNodeMap* entitiesForBindings() const { return nullptr; }
    4242    NamedNodeMap* notationsForBindings() const { return nullptr; }
     43    String internalSubsetForBindings() const { return String(); }
    4344
    4445    const String& name() const { return m_name; }
    4546    const String& publicId() const { return m_publicId; }
    4647    const String& systemId() const { return m_systemId; }
    47     const String& internalSubset() const { return m_subset; }
    4848
    4949private:
    … …  
    5757    String m_publicId;
    5858    String m_systemId;
    59     String m_subset;
    6059};
    6160

  • trunk/Source/WebCore/dom/DocumentType.idl

    r197060 r204114  
    3030    [ImplementedAs=entitiesForBindings] readonly attribute NamedNodeMap entities;
    3131    [ImplementedAs=notationsForBindings] readonly attribute NamedNodeMap notations;
     32    [ImplementedAs=internalSubsetForBindings] readonly attribute DOMString? internalSubset;
    3233#endif
    3334
    … …  
    3637    readonly attribute DOMString publicId;
    3738    readonly attribute DOMString systemId;
    38     readonly attribute DOMString? internalSubset;
    3939};
    4040

  • trunk/Source/WebCore/dom/Node.cpp

    r203759 r204114  
    12271227        if (thisDocType.systemId() != otherDocType.systemId())
    12281228            return false;
    1229         if (thisDocType.internalSubset() != otherDocType.internalSubset())
    1230             return false;
    12311229        break;
    12321230        }

  • trunk/Source/WebCore/editing/MarkupAccumulator.cpp

    r203389 r204114  
    405405        result.append('"');
    406406    }
    407     if (!documentType.internalSubset().isNull()) {
    408         result.append(' ');
    409         result.append('[');
    410         result.append(documentType.internalSubset());
    411         result.append(']');
    412     }
    413407    result.append('>');
    414408}

  • trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp

    r203337 r204114  
    14021402        value->setPublicId(docType.publicId());
    14031403        value->setSystemId(docType.systemId());
    1404         value->setInternalSubset(docType.internalSubset());
    14051404    } else if (is<Attr>(*node)) {
    14061405        Attr& attribute = downcast<Attr>(*node);

  • trunk/Source/WebInspectorUI/ChangeLog

    r204099 r204114  
     12016-08-03  Chris Dumez  <cdumez@apple.com>
     2
     3        Drop DocumentType.internalSubset attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=160530
     5
     6        Reviewed by Alex Christensen.
     7
     8        Drop DocumentType.internalSubset attribute.
     9
     10        * UserInterface/Models/DOMNode.js:
     11        (WebInspector.DOMNode): Deleted.
     12        * UserInterface/Models/DOMSearchMatchObject.js:
     13        (WebInspector.DOMSearchMatchObject.titleForDOMNode): Deleted.
     14        * UserInterface/Views/DOMTreeElement.js:
     15        (WebInspector.DOMTreeElement.prototype._nodeTitleInfo): Deleted.
     16
    1172016-08-03  Matt Baker  <mattbaker@apple.com>
    218

  • trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js

    r202634 r204114  
    123123            this.publicId = payload.publicId;
    124124            this.systemId = payload.systemId;
    125             this.internalSubset = payload.internalSubset;
    126125        } else if (this._nodeType === Node.DOCUMENT_NODE) {
    127126            this.documentURL = payload.documentURL;

  • trunk/Source/WebInspectorUI/UserInterface/Models/DOMSearchMatchObject.js

    r181769 r204114  
    6868            } else if (domNode.systemId)
    6969                title += " SYSTEM \"" + domNode.systemId + "\"";
    70 
    71             if (domNode.internalSubset)
    72                 title += " [" + domNode.internalSubset + "]";
    7370
    7471            return title + ">";

  • trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js

    r202634 r204114  
    13071307                    docTypeElement.append(" SYSTEM \"" + node.systemId + "\"");
    13081308
    1309                 if (node.internalSubset)
    1310                     docTypeElement.append(" [" + node.internalSubset + "]");
    1311 
    13121309                docTypeElement.append(">");
    13131310                break;
Note: See TracChangeset for help on using the changeset viewer.