Changeset 204156 in webkit

Timestamp:

Aug 4, 2016, 5:46:05 PM (9 years ago)

Author:

commit-queue@webkit.org

Message:

UI improvements to Flakiness Dashboard.
​https://bugs.webkit.org/show_bug.cgi?id=153295

Patch by Dean Johnson <​dean_johnson@apple.com> on 2016-08-04
Reviewed by Alexey Proskuryakov.

• TestResultServer/static-dashboards/flakiness_dashboard.css:

(td.options-container): Center text in most fields.

• TestResultServer/static-dashboards/flakiness_dashboard.js:

(createBugHTML): Text/Grammar updates.
(tableHeaders): Ditto.
(htmlForSingleTestRow): Ditto.
(headerForTestTableHtml): Ditto.

• TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.

(ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestResultServer/static-dashboards/flakiness_dashboard.css (modified) (1 diff)
• TestResultServer/static-dashboards/flakiness_dashboard.js (modified) (5 diffs)
• TestResultServer/static-dashboards/ui.js (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-08-04  Dean Johnson  <dean_johnson@apple.com>
+
+        UI improvements to Flakiness Dashboard.
+        https://bugs.webkit.org/show_bug.cgi?id=153295
+
+        Reviewed by Alexey Proskuryakov.
+
+        * TestResultServer/static-dashboards/flakiness_dashboard.css:
+        (td.options-container): Center text in most fields.
+        * TestResultServer/static-dashboards/flakiness_dashboard.js:
+        (createBugHTML): Text/Grammar updates.
+        (tableHeaders): Ditto.
+        (htmlForSingleTestRow): Ditto.
+        (headerForTestTableHtml): Ditto.
+        * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
+        (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
+
 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.css

@@ -48 +48 @@
     white-space: nowrap;
 }
+td.options-container {
+    text-align: center;
+}
 .forms {
     display: -webkit-box;

trunk/Tools/TestResultServer/static-dashboards/flakiness_dashboard.js

@@ -1329 +1329 @@
     var component = encodeURIComponent('Tools / Tests');
     url = 'https://bugs.webkit.org/enter_bug.cgi?assigned_to=webkit-unassigned%40lists.webkit.org&product=WebKit&form_name=enter_bug&component=' + component + '&short_desc=' + title + '&comment=' + description;
-    return '<a href="' + url + '" class="file-bug">FILE BUG</a>';
+    return '<a href="' + url + '" class="file-bug">File</a>';
 }
 
@@ -1341 +1341 @@
     var headers = [];
     if (isCrossBuilderView() || opt_getAll)
-        headers.push('builder');
+        headers.push('Builder');
 
     if (!isCrossBuilderView() || opt_getAll)
-        headers.push('test');
+        headers.push('Test');
 
     if (g_history.isLayoutTestResults() || opt_getAll)
-        headers.push('bugs', 'modifiers', 'expectations');
-
-    headers.push('slowest run', 'flakiness (numbers are runtimes in seconds)');
+        headers.push('Bug(s)', 'Modifiers', 'Expectation(s)');
+
+    headers.push('Slowest Run', 'Flakiness (Numbers are runtimes in seconds)');
     return headers;
 }
@@ -1367 +1367 @@
     for (var i = 0; i < headers.length; i++) {
         var header = headers[i];
-        if (string.startsWith(header, 'test') || string.startsWith(header, 'builder')) {
+        if (string.startsWith(header, 'Test') || string.startsWith(header, 'Builder')) {
             // If isCrossBuilderView() is true, we're just viewing a single test
             // with results for many builders, so the first column is builder names
@@ -1375 +1375 @@
 
             html += '<tr><td class="' + testCellClassName + '">' + testCellHTML;
-        } else if (string.startsWith(header, 'bugs'))
-            html += '<td class=options-container>' + (test.bugs ? htmlForBugs(test.bugs) : createBugHTML(test));
-        else if (string.startsWith(header, 'modifiers'))
+        } else if (string.startsWith(header, 'Bug(s)'))
+            html += '<td class=options-container bugs>' + (test.bugs ? htmlForBugs(test.bugs) : createBugHTML(test));
+        else if (string.startsWith(header, 'Modifiers'))
             html += '<td class=options-container>' + test.modifiers;
-        else if (string.startsWith(header, 'expectations'))
-            html += '<td class=options-container>' + test.expectations;
-        else if (string.startsWith(header, 'slowest'))
-            html += '<td>' + (test.slowestTime ? test.slowestTime + 's' : '');
-        else if (string.startsWith(header, 'flakiness'))
+        else if (string.startsWith(header, 'Expectation(s)'))
+            html += '<td class=options-container>' + test.expectations.split(' ').join(' | ');
+        else if (string.startsWith(header, 'Slowest'))
+            html += '<td class=options-container>' + (test.slowestTime ? test.slowestTime + 's' : '');
+        else if (string.startsWith(header, 'Flakiness'))
             html += htmlForTestResults(test);
     }
@@ -2178 +2178 @@
 function headerForTestTableHtml()
 {
-    return '<h2 style="display:inline-block">Failing tests</h2>' +
-        checkBoxToToggleState('showWontFixSkip', 'WONTFIX/SKIP') +
-        checkBoxToToggleState('showCorrectExpectations', 'tests with correct expectations') +
-        checkBoxToToggleState('showWrongExpectations', 'tests with wrong expectations') +
-        checkBoxToToggleState('showFlaky', 'flaky') +
-        checkBoxToToggleState('showSlow', 'slow');
+    return '<h2 style="display:inline-block">Show Tests Flagged As/With: </h2>' +
+        checkBoxToToggleState('showWontFixSkip', "Won't Fix/Skip") +
+        checkBoxToToggleState('showCorrectExpectations', 'Correct Expectations') +
+        checkBoxToToggleState('showWrongExpectations', 'Incorrect Expectations') +
+        checkBoxToToggleState('showFlaky', 'Flaky') +
+        checkBoxToToggleState('showSlow', 'Slow');
 }
 

trunk/Tools/TestResultServer/static-dashboards/ui.js

@@ -111 +111 @@
         ui.html._dashboardLink('Treemap', 'treemap.html');
 
-    html += ui.html.select('Test type', 'testType', TEST_TYPES);
-
     if (!opt_noBuilderMenu) {
         var buildersForMenu = Object.keys(currentBuilders());
@@ -119 +117 @@
         html += ui.html.select('Builder', 'builder', buildersForMenu);
     }
-
-    html += ui.html.select('Group', 'group',
-        Object.keys(currentBuilderGroupCategory()));
 
     if (!history.isTreeMap())