Changeset 204159 in webkit

Timestamp:

Aug 4, 2016, 7:35:28 PM (9 years ago)

Author:

mmaxfield@apple.com

Message:

[iOS] Some videos in iBooks erroneously go fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=160582
<rdar://problem/27669831>

Reviewed by Jon Lee.

No new tests because we can't currently mock the iBooks application bundle ID.

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/MediaElementSession.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2016-08-04  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        [iOS] Some videos in iBooks erroneously go fullscreen
+        https://bugs.webkit.org/show_bug.cgi?id=160582
+        <rdar://problem/27669831>
+
+        Reviewed by Jon Lee.
+
+        No new tests because we can't currently mock the iBooks application bundle ID.
+
+        * html/MediaElementSession.cpp:
+        (WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):
+
 2016-08-04  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebCore/html/MediaElementSession.cpp

@@ -471 +471 @@
 
 #if PLATFORM(IOS)
+    if (IOSApplication::isIBooks())
+        return !element.hasAttributeWithoutSynchronization(HTMLNames::webkit_playsinlineAttr) && !element.hasAttributeWithoutSynchronization(HTMLNames::playsinlineAttr);
     if (dyld_get_program_sdk_version() < DYLD_IOS_VERSION_10_0)
         return !element.hasAttributeWithoutSynchronization(HTMLNames::webkit_playsinlineAttr);