Changeset 204167 in webkit

Timestamp:

Aug 5, 2016, 6:43:49 AM (9 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r204123.
​https://bugs.webkit.org/show_bug.cgi?id=160597

Caused layout test timeouts on Windows. (Requested by perarne
on #webkit).

Reverted changeset:

"[Win] Unable to reliably run tests in parallel"
​https://bugs.webkit.org/show_bug.cgi?id=140914
​http://trac.webkit.org/changeset/204123

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/common/system/path.py (modified) (2 diffs)
• Scripts/webkitpy/port/driver.py (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-08-05  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r204123.
+        https://bugs.webkit.org/show_bug.cgi?id=160597
+
+        Caused layout test timeouts on Windows. (Requested by perarne
+        on #webkit).
+
+        Reverted changeset:
+
+        "[Win] Unable to reliably run tests in parallel"
+        https://bugs.webkit.org/show_bug.cgi?id=140914
+        http://trac.webkit.org/changeset/204123
+
 2016-08-04  Saam Barati  <sbarati@apple.com>
 

trunk/Tools/Scripts/webkitpy/common/system/path.py

@@ -31 +31 @@
 import atexit
 import os
-import re
 import subprocess
 import sys
@@ -52 +51 @@
     return path
 
-
-def cygpathFast(path):
-    """Converts an absolute cygwin path to an absolute Windows path with string replacement."""
-    if sys.platform == 'cygwin':
-        path = re.sub('/cygdrive/c', 'c:', path)
-        path = re.sub('/', r'\\', path)
-    return path
 
 # Note that this object is not threadsafe and must only be called

trunk/Tools/Scripts/webkitpy/port/driver.py

@@ -457 +457 @@
             command = self._port.abspath_for_test(driver_input.test_name)
             if sys.platform == 'cygwin':
-                command = path.cygpathFast(command)
+                command = path.cygpath(command)
 
         assert not driver_input.image_hash or driver_input.should_run_pixel_test