Changeset 204631 in webkit
- Timestamp:
- Aug 19, 2016 8:46:42 AM (8 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r204630 r204631 1 2016-08-19 Chris Dumez <cdumez@apple.com> 2 3 DumpRenderTree crashed in com.apple.WebCore: WebCore::DOMWindow::resetDOMWindowProperties + 607 4 https://bugs.webkit.org/show_bug.cgi?id=160983 5 <rdar://problem/26768524> 6 7 Reviewed by Brent Fulgham. 8 9 Update DOMWindow::frameDestroyed() to ref the window object as the crash 10 traces seem to indicate it can get destroyed during the execution of this 11 method. Also update the code in the ~Frame destructor to not iterate over 12 the list of FrameDestructionObservers because observers remove themselves 13 from the list when they get destroyed. 14 15 No new tests, do not know how to reproduce. 16 17 * page/DOMWindow.cpp: 18 (WebCore::DOMWindow::frameDestroyed): 19 * page/Frame.cpp: 20 (WebCore::Frame::~Frame): 21 1 22 2016-08-19 Chris Dumez <cdumez@apple.com> 2 23 -
trunk/Source/WebCore/page/DOMWindow.cpp
r204429 r204631 482 482 void DOMWindow::frameDestroyed() 483 483 { 484 Ref<DOMWindow> protectedThis(*this); 485 484 486 willDestroyDocumentInFrame(); 485 487 FrameDestructionObserver::frameDestroyed(); -
trunk/Source/WebCore/page/Frame.cpp
r203324 r204631 218 218 disconnectOwnerElement(); 219 219 220 for (auto& observer : m_destructionObservers)221 observer->frameDestroyed();220 while (auto* destructionObserver = m_destructionObservers.takeAny()) 221 destructionObserver->frameDestroyed(); 222 222 223 223 if (!isMainFrame())
Note: See TracChangeset
for help on using the changeset viewer.