Changeset 205087 in webkit

Timestamp:

Aug 27, 2016, 5:11:49 PM (10 years ago)

Author:

ap@apple.com

Message:

REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
​https://bugs.webkit.org/show_bug.cgi?id=161254

Reviewed by Darin Adler.

Simplify the CSS. My understanding that the CSS was correct, and the root cause
is tracked in bug 160478.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css (modified) (1 diff)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css

@@ -55 +55 @@
 
 .popover.step-in {
-    transition: opacity 0ms;
-    /* This is a delay after popover creation. Popover tracking code may add a delay of its own before it decides to create the popover. */
+    /* The delay is after popover creation. Popover tracking code may add a delay of its own before it decides to create the popover. */
     /* It is useful to separate the delays because popover creation can be costly, e.g. it can lazily load data from network during the transition. */
-    transition-delay: 800ms;
+    transition: opacity 0ms 800ms;
     opacity: 1;
 }
 
 .popover.fade-out {
-    transition: opacity 500ms;
-    transition-delay: 200ms;
+    transition: opacity 500ms 200ms;
     opacity: 0;
 }

trunk/Tools/ChangeLog

@@ +1 @@
+2016-08-27  Alexey Proskuryakov  <ap@apple.com>
+
+        REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
+        https://bugs.webkit.org/show_bug.cgi?id=161254
+
+        Reviewed by Darin Adler.
+
+        Simplify the CSS. My understanding that the CSS was correct, and the root cause
+        is tracked in bug 160478.
+
+        * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
+
 2016-08-27  Simon Fraser  <simon.fraser@apple.com>