Changeset 206094 in webkit


Ignore:
Timestamp:
Sep 19, 2016 5:30:53 AM (8 years ago)
Author:
nael.ouedraogo@crf.canon.fr
Message:

If a host object is only used as a variadic argument, its bindings header isn't properly included
https://bugs.webkit.org/show_bug.cgi?id=150121

Reviewed by Youenn Fablet.

Modify JS binding generator to include binding headers of objects passed
as variadic argument.

  • Modules/mediastream/RTCPeerConnection.h: Remove workaround.
  • bindings/scripts/CodeGeneratorJS.pm:

(AddVariadicToImplIncludes):
(GenerateParametersCheck):

  • bindings/scripts/test/JS/JSTestObj.cpp:
Location:
trunk/Source/WebCore
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r206093 r206094  
     12016-09-19  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
     2
     3        If a host object is only used as a variadic argument, its bindings header isn't properly included
     4        https://bugs.webkit.org/show_bug.cgi?id=150121
     5
     6        Reviewed by Youenn Fablet.
     7
     8        Modify JS binding generator to include binding headers of objects passed
     9        as variadic argument.
     10
     11        * Modules/mediastream/RTCPeerConnection.h: Remove workaround.
     12        * bindings/scripts/CodeGeneratorJS.pm:
     13        (AddVariadicToImplIncludes):
     14        (GenerateParametersCheck):
     15        * bindings/scripts/test/JS/JSTestObj.cpp:
     16
    1172016-09-19  Joseph Pecoraro  <pecoraro@apple.com>
    218
  • trunk/Source/WebCore/Modules/mediastream/RTCPeerConnection.h

    r205542 r206094  
    3939#include "Dictionary.h"
    4040#include "EventTarget.h"
    41 // FIXME: Workaround for bindings bug http://webkit.org/b/150121
    42 #include "JSMediaStream.h"
     41#include "MediaStream.h"
    4342#include "PeerConnectionBackend.h"
    4443#include "RTCRtpTransceiver.h"
     
    4948namespace WebCore {
    5049
    51 class MediaStream;
    5250class MediaStreamTrack;
    5351class PeerConnectionBackend;
  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r206090 r206094  
    40034003            $value = "WTFMove($name)";
    40044004        } elsif ($parameter->isVariadic) {
     4005            AddToImplIncludes("JS${type}.h", $function->signature->extendedAttributes->{"Conditional"}) unless $codeGenerator->SkipIncludeHeader($type) or !$codeGenerator->IsWrapperType($type);
    40054006            my ($wrapperType, $wrappedType) = GetVariadicType($interface, $type);
    40064007            push(@$outputArray, "    auto $name = toArguments<VariadicHelper<$wrapperType, $wrappedType>>(*state, $argumentIndex);\n");
  • trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp

    r206090 r206094  
    3232#include "Frame.h"
    3333#include "HTMLNames.h"
     34#include "JSBlob.h"
    3435#include "JSDOMBinding.h"
    3536#include "JSDOMConstructor.h"
Note: See TracChangeset for help on using the changeset viewer.