Changeset 206147 in webkit

Timestamp:

Sep 20, 2016 8:45:43 AM (8 years ago)

Author:

Yusuke Suzuki

Message:

[JSC] Add typeof value === "symbol" handling to bytecode compiler
​https://bugs.webkit.org/show_bug.cgi?id=162253

Reviewed by Sam Weinig.

JSTests:

• microbenchmarks/is-symbol-mixed.js: Added.

(isSymbol):
(i.let.pair.of.list.String):

• microbenchmarks/is-symbol.js: Added.

(isSymbol):

Source/JavaScriptCore:

Add typeof value === "symbol" handling to the bytecode compiler.
The effect is tiny, but it keeps consistency since the bytecode compiler
already has the similar optimization for "string" case.

• bytecode/SpeculatedType.cpp:

(JSC::speculationFromJSType):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEqualityOp):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/microbenchmarks/is-symbol-mixed.js (added)
• JSTests/microbenchmarks/is-symbol.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/bytecode/SpeculatedType.cpp (modified) (1 diff)
• Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2016-09-20  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [JSC] Add `typeof value === "symbol"` handling to bytecode compiler
+        https://bugs.webkit.org/show_bug.cgi?id=162253
+
+        Reviewed by Sam Weinig.
+
+        * microbenchmarks/is-symbol-mixed.js: Added.
+        (isSymbol):
+        (i.let.pair.of.list.String):
+        * microbenchmarks/is-symbol.js: Added.
+        (isSymbol):
+
 2016-09-19  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2016-09-20  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [JSC] Add `typeof value === "symbol"` handling to bytecode compiler
+        https://bugs.webkit.org/show_bug.cgi?id=162253
+
+        Reviewed by Sam Weinig.
+
+        Add `typeof value === "symbol"` handling to the bytecode compiler.
+        The effect is tiny, but it keeps consistency since the bytecode compiler
+        already has the similar optimization for "string" case.
+
+        * bytecode/SpeculatedType.cpp:
+        (JSC::speculationFromJSType):
+        * bytecompiler/BytecodeGenerator.cpp:
+        (JSC::BytecodeGenerator::emitEqualityOp):
+
 2016-09-19  Saam Barati  <sbarati@apple.com>
 

trunk/Source/JavaScriptCore/bytecode/SpeculatedType.cpp

@@ -477 +477 @@
     case StringType:
         return SpecString;
+    case SymbolType:
+        return SpecSymbol;
     case ArrayType:
         return SpecArray;

trunk/Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp

@@ -1664 +1664 @@
                 instructions().append(srcIndex);
                 instructions().append(StringType);
+                return dst;
+            }
+            if (value == "symbol") {
+                rewindUnaryOp();
+                emitOpcode(op_is_cell_with_type);
+                instructions().append(dst->index());
+                instructions().append(srcIndex);
+                instructions().append(SymbolType);
                 return dst;
             }