Changeset 206171 in webkit

Timestamp:

Sep 20, 2016 1:57:31 PM (8 years ago)

Author:

commit-queue@webkit.org

Message:

[JSC] Do not use EagerRun on tests counting recompilation
​https://bugs.webkit.org/show_bug.cgi?id=162248

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-09-20
Reviewed by Geoffrey Garen.

This patch adds defaultNoEagerRun to all the tests
for which recompilation is the symptom of a bug.
The reason is that an OSR Exit can be unrelated to the tested
nodes when we are running in Eager mode.

• stress/arith-abs-on-various-types.js:
• stress/arith-ceil-on-various-types.js:
• stress/arith-clz32-on-various-types.js:
• stress/arith-cos-on-various-types.js:
• stress/arith-floor-on-various-types.js:
• stress/arith-fround-on-various-types.js:
• stress/arith-log-on-various-types.js:
• stress/arith-round-on-various-types.js:
• stress/arith-sin-on-various-types.js:
• stress/arith-sqrt-on-various-types.js:
• stress/arith-tan-on-various-types.js:
• stress/arith-trunc-on-various-types.js:

• stress/compare-strict-eq-on-various-types.js:

(testAllTypesCall):
The value 2 came from the other tests.
CompareStrictEq supports many more cases, the worst case
is bool->int->int52->number->polymorphic.

Location:

trunk/JSTests

Files:

• ChangeLog (modified) (1 diff)
• stress/arith-abs-on-various-types.js (modified) (1 diff)
• stress/arith-ceil-on-various-types.js (modified) (1 diff)
• stress/arith-clz32-on-various-types.js (modified) (1 diff)
• stress/arith-cos-on-various-types.js (modified) (1 diff)
• stress/arith-floor-on-various-types.js (modified) (1 diff)
• stress/arith-fround-on-various-types.js (modified) (1 diff)
• stress/arith-log-on-various-types.js (modified) (1 diff)
• stress/arith-round-on-various-types.js (modified) (1 diff)
• stress/arith-sin-on-various-types.js (modified) (1 diff)
• stress/arith-sqrt-on-various-types.js (modified) (1 diff)
• stress/arith-tan-on-various-types.js (modified) (1 diff)
• stress/arith-trunc-on-various-types.js (modified) (1 diff)
• stress/compare-strict-eq-on-various-types.js (modified) (2 diffs)

trunk/JSTests/ChangeLog

@@ +1 @@
+2016-09-20  Benjamin Poulain  <bpoulain@apple.com>
+
+        [JSC] Do not use EagerRun on tests counting recompilation
+        https://bugs.webkit.org/show_bug.cgi?id=162248
+
+        Reviewed by Geoffrey Garen.
+
+        This patch adds defaultNoEagerRun to all the tests
+        for which recompilation is the symptom of a bug.
+        The reason is that an OSR Exit can be unrelated to the tested
+        nodes when we are running in Eager mode.
+
+        * stress/arith-abs-on-various-types.js:
+        * stress/arith-ceil-on-various-types.js:
+        * stress/arith-clz32-on-various-types.js:
+        * stress/arith-cos-on-various-types.js:
+        * stress/arith-floor-on-various-types.js:
+        * stress/arith-fround-on-various-types.js:
+        * stress/arith-log-on-various-types.js:
+        * stress/arith-round-on-various-types.js:
+        * stress/arith-sin-on-various-types.js:
+        * stress/arith-sqrt-on-various-types.js:
+        * stress/arith-tan-on-various-types.js:
+        * stress/arith-trunc-on-various-types.js:
+
+        * stress/compare-strict-eq-on-various-types.js:
+        (testAllTypesCall):
+        The value 2 came from the other tests.
+        CompareStrictEq supports many more cases, the worst case
+        is bool->int->int52->number->polymorphic.
+
 2016-09-20  Filip Pizlo  <fpizlo@apple.com>
 

trunk/JSTests/stress/arith-abs-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 

trunk/JSTests/stress/arith-ceil-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 

trunk/JSTests/stress/arith-clz32-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 

trunk/JSTests/stress/arith-cos-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 

trunk/JSTests/stress/arith-floor-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 

trunk/JSTests/stress/arith-fround-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 

trunk/JSTests/stress/arith-log-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 

trunk/JSTests/stress/arith-round-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 

trunk/JSTests/stress/arith-sin-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 

trunk/JSTests/stress/arith-sqrt-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 

trunk/JSTests/stress/arith-tan-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 

trunk/JSTests/stress/arith-trunc-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 

trunk/JSTests/stress/compare-strict-eq-on-various-types.js

@@ +1 @@
+//@ defaultNoEagerRun
 "use strict";
 
@@ -97 +98 @@
         }
     }
-    if (numberOfDFGCompiles(opaqueStrictEqualAllTypes) > 2)
+    if (numberOfDFGCompiles(opaqueStrictEqualAllTypes) > 5)
         throw "opaqueStrictEqualAllTypes() should have been quickly compiled as fully polymorphic.";
-    if (opaqueStrictNotEqualAllTypes(opaqueStrictEqualAllTypes) > 2)
+    if (opaqueStrictNotEqualAllTypes(opaqueStrictEqualAllTypes) > 5)
         throw "opaqueStrictEqualAllTypes() should have been quickly compiled as fully polymorphic.";
 }