Changeset 206179 in webkit


Ignore:
Timestamp:
Sep 20, 2016 3:19:16 PM (8 years ago)
Author:
achristensen@apple.com
Message:

Fix occasional using uninitialized memory crashes after r206168.
​https://bugs.webkit.org/show_bug.cgi?id=162247

This fixes a crash in imported/w3c/web-platform-tests/url/urlsearchparams-constructor.html
I could reproduce about 10% of the time.

  • html/URLSearchParams.h:

Initialize the pointer to nullptr.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r206177 r206179  
     12016-09-20  Alex Christensen  <achristensen@webkit.org>
     2
     3        Fix occasional using uninitialized memory crashes after r206168.
     4        https://bugs.webkit.org/show_bug.cgi?id=162247
     5
     6        This fixes a crash in imported/w3c/web-platform-tests/url/urlsearchparams-constructor.html
     7        I could reproduce about 10% of the time.
     8
     9        * html/URLSearchParams.h:
     10        Initialize the pointer to nullptr.
     11
    1122016-09-20  Alex Christensen  <achristensen@webkit.org>
    213

  • trunk/Source/WebCore/html/URLSearchParams.h

    r206168 r206179  
    5252    void updateURL();
    5353
    54     DOMURL* m_associatedURL;
     54    DOMURL* m_associatedURL { nullptr };
    5555    Vector<std::pair<String, String>> m_pairs;
    5656};
Note: See TracChangeset for help on using the changeset viewer.