Changeset 206182 in webkit

Timestamp:

Sep 20, 2016 3:36:02 PM (8 years ago)

Author:

ap@apple.com

Message:

Use a hardcoded patch for sRGB color profile
​https://bugs.webkit.org/show_bug.cgi?id=162320
rdar://problem/28387318

Reviewed by Simon Fraser.

This is a workaround for rdar://problem/28392768

• DumpRenderTree/mac/LayoutTestHelper.m:

(installLayoutTestColorProfile):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/mac/LayoutTestHelper.m (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2016-09-20  Alexey Proskuryakov  <ap@apple.com>
+
+        Use a hardcoded patch for sRGB color profile
+        https://bugs.webkit.org/show_bug.cgi?id=162320
+        rdar://problem/28387318
+
+        Reviewed by Simon Fraser.
+
+        This is a workaround for rdar://problem/28392768
+
+        * DumpRenderTree/mac/LayoutTestHelper.m:
+        (installLayoutTestColorProfile):
+
 2016-09-20  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Tools/DumpRenderTree/mac/LayoutTestHelper.m

@@ -173 +173 @@
     saveDisplayColorProfiles(displays);
 
-    ColorSyncProfileRef sRGBProfile = ColorSyncProfileCreateWithName(kColorSyncSRGBProfile);
-    CFErrorRef error;
-    CFURLRef profileURL = ColorSyncProfileGetURL(sRGBProfile, &error);
-    if (!profileURL) {
-        NSLog(@"Failed to get URL of Generic RGB color profile! Many pixel tests may fail as a result. Error: %@", error);
-        return;
-    }
+    // Profile path needs to be hardcoded because of <rdar://problem/28392768>.
+    NSURL *sRGBProfileURL = [NSURL fileURLWithPath:@"/System/Library/ColorSync/Profiles/sRGB Profile.icc"];
     
     for (NSString *displayUUIDString in displays)
-        setDisplayColorProfile(displayUUIDString, (NSURL *)profileURL);
+        setDisplayColorProfile(displayUUIDString, sRGBProfileURL);
 }