Changeset 206239 in webkit


Ignore:
Timestamp:
Sep 21, 2016 3:52:37 PM (8 years ago)
Author:
commit-queue@webkit.org
Message:

Inline function only used in one place
https://bugs.webkit.org/show_bug.cgi?id=162363

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-09-21
Reviewed by Saam Barati.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitBytecode):
(JSC::ForInNode::emitMultiLoopBytecode):

  • parser/Nodes.h:

No need for the extra function, it adds no clarification.

Location:
trunk/Source/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r206236 r206239  
     12016-09-21  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Inline function only used in one place
     4        https://bugs.webkit.org/show_bug.cgi?id=162363
     5
     6        Reviewed by Saam Barati.
     7
     8        * bytecompiler/NodesCodegen.cpp:
     9        (JSC::ForInNode::emitBytecode):
     10        (JSC::ForInNode::emitMultiLoopBytecode):
     11        * parser/Nodes.h:
     12        No need for the extra function, it adds no clarification.
     13
    1142016-09-21  Commit Queue  <commit-queue@webkit.org>
    215
  • trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp

    r206104 r206239  
    26862686}
    26872687
    2688 void ForInNode::emitMultiLoopBytecode(BytecodeGenerator& generator, RegisterID* dst)
     2688void ForInNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
    26892689{
    26902690    if (!m_lexpr->isAssignResolveNode() && !m_lexpr->isAssignmentLocation()) {
     
    28342834    generator.popLexicalScope(this);
    28352835    generator.emitProfileControlFlow(profilerEndOffset);
    2836 }
    2837 
    2838 void ForInNode::emitBytecode(BytecodeGenerator& generator, RegisterID* dst)
    2839 {
    2840     this->emitMultiLoopBytecode(generator, dst);
    28412836}
    28422837
  • trunk/Source/JavaScriptCore/parser/Nodes.h

    r205462 r206239  
    14761476        RegisterID* tryGetBoundLocal(BytecodeGenerator&);
    14771477        void emitLoopHeader(BytecodeGenerator&, RegisterID* propertyName);
    1478         void emitMultiLoopBytecode(BytecodeGenerator&, RegisterID* dst);
    14791478
    14801479        void emitBytecode(BytecodeGenerator&, RegisterID* = 0) override;
Note: See TracChangeset for help on using the changeset viewer.