Changeset 206240 in webkit
- Timestamp:
- Sep 21, 2016 3:52:42 PM (8 years ago)
- Location:
- trunk
- Files:
-
- 7 edited
-
LayoutTests/ChangeLog (modified) (1 diff)
-
LayoutTests/editing/pasteboard/paste-noscript-expected.txt (modified) (1 diff)
-
LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
-
LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt (modified) (1 diff)
-
LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt (modified) (2 diffs)
-
Source/WebCore/ChangeLog (modified) (1 diff)
-
Source/WebCore/editing/MarkupAccumulator.h (modified) (1 diff)
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r206237 r206240 1 2016-09-21 Chris Dumez <cdumez@apple.com> 2 3 Fix serialization of HTML Element attributes 4 https://bugs.webkit.org/show_bug.cgi?id=162356 5 6 Reviewed by Alex Christensen. 7 8 Rebaseline test to reflect behavior change. 9 10 * editing/pasteboard/paste-noscript-expected.txt: 11 1 12 2016-09-21 Matt Baker <mattbaker@apple.com> 2 13 -
trunk/LayoutTests/editing/pasteboard/paste-noscript-expected.txt
r147281 r206240 16 16 <iframe id="iframe1" src="javascript:var x = 1;" style="width: 200px; height: 100px; background-color:#cee;"></iframe> 17 17 <iframe id="iframe1" style="width: 200px; height: 100px; background-color: rgb(204, 238, 238);"></iframe> 18 <iframe id="iframe2" srcdoc=" <script>var x = 1;</script>" style="width: 200px; height: 100px; background-color:#cee;"></iframe>18 <iframe id="iframe2" srcdoc="<script>var x = 1;</script>" style="width: 200px; height: 100px; background-color:#cee;"></iframe> 19 19 <iframe id="iframe2" style="width: 200px; height: 100px; background-color: rgb(204, 238, 238);"></iframe> 20 20 <form id="form1" action="javascript:sayHello()" formaction="javascript:sayHello()" style="width: 200px; height: 150px; background-color:#cee;">This is a form<br><img src="../resources/abe.png"><button formaction="javascript:sayHello()">Submit.</button></form> -
trunk/LayoutTests/imported/w3c/ChangeLog
r206233 r206240 1 2016-09-21 Chris Dumez <cdumez@apple.com> 2 3 Fix serialization of HTML Element attributes 4 https://bugs.webkit.org/show_bug.cgi?id=162356 5 6 Reviewed by Alex Christensen. 7 8 Rebaseline W3C test now that more checks are passing. 9 10 * web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt: 11 * web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt: 12 1 13 2016-09-21 Chris Dumez <cdumez@apple.com> 2 14 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt
r205515 r206240 11 11 FAIL <img srcset="/images/green-256x256.png 256w" sizes="1px" data-expect="1"> assert_equals: naturalWidth expected 1 but got 256 12 12 FAIL <img srcset="/images/green-256x256.png 256w" sizes="0px" data-expect="0"> assert_equals: naturalWidth expected 0 but got 256 13 PASS <img srcset="data:image/svg+xml, <svg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='-1%20-1%202%202'%20width='20'%20height='20'><circle%20r='1'/></svg>2x" data-expect="10">14 PASS <img srcset="data:image/svg+xml, <svg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='-1%20-1%202%202'%20width='20'><circle%20r='1'/></svg>2x" data-expect="10">15 PASS <img srcset="data:image/svg+xml, <svg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='-1%20-1%202%202'%20height='20'><circle%20r='1'/></svg>2x" data-expect="10">13 PASS <img srcset="data:image/svg+xml,<svg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='-1%20-1%202%202'%20width='20'%20height='20'><circle%20r='1'/></svg> 2x" data-expect="10"> 14 PASS <img srcset="data:image/svg+xml,<svg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='-1%20-1%202%202'%20width='20'><circle%20r='1'/></svg> 2x" data-expect="10"> 15 PASS <img srcset="data:image/svg+xml,<svg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='-1%20-1%202%202'%20height='20'><circle%20r='1'/></svg> 2x" data-expect="10"> 16 16 -
trunk/LayoutTests/imported/w3c/web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt
r206201 r206240 7 7 PASS innerHTML 5 <a b=" "></a> 8 8 PASS innerHTML 6 <a b="""></a> 9 FAIL innerHTML 7 <a b="<"></a> assert_equals: expected "<a b=\"<\"></a>" but got "<a b=\"<\"></a>" 10 FAIL innerHTML 8 <a b=">"></a> assert_equals: expected "<a b=\">\"></a>" but got "<a b=\">\"></a>" 9 PASS innerHTML 7 <a b="<"></a> 10 PASS innerHTML 8 <a b=">"></a> 11 11 PASS innerHTML 9 <svg xlink:href="a"></svg> 12 12 PASS innerHTML 10 <svg xmlns:svg="test"></svg> … … 34 34 PASS outerHTML 5 <span><a b=" "></a></span> 35 35 PASS outerHTML 6 <span><a b="""></a></span> 36 FAIL outerHTML 7 <span><a b="<"></a></span> assert_equals: expected "<span><a b=\"<\"></a></span>" but got "<span><a b=\"<\"></a></span>" 37 FAIL outerHTML 8 <span><a b=">"></a></span> assert_equals: expected "<span><a b=\">\"></a></span>" but got "<span><a b=\">\"></a></span>" 36 PASS outerHTML 7 <span><a b="<"></a></span> 37 PASS outerHTML 8 <span><a b=">"></a></span> 38 38 PASS outerHTML 9 <span><svg xlink:href="a"></svg></span> 39 39 PASS outerHTML 10 <span><svg xmlns:svg="test"></svg></span> -
trunk/Source/WebCore/ChangeLog
r206238 r206240 1 2016-09-21 Chris Dumez <cdumez@apple.com> 2 3 Fix serialization of HTML Element attributes 4 https://bugs.webkit.org/show_bug.cgi?id=162356 5 6 Reviewed by Alex Christensen. 7 8 Fix serialization of HTML Element attributes to align with: 9 - https://html.spec.whatwg.org/#html-fragment-serialisation-algorithm 10 - https://html.spec.whatwg.org/#escapingString 11 12 In particular, we should not escape '<' and '>'. 13 14 Firefox and Chrome both match the specification. 15 16 Note that we keep escaping '<' and '>' for Element attributes in the 17 context of XML serialization, as per: 18 - https://w3c.github.io/DOM-Parsing/#dfn-serializing-an-attribute-value 19 20 No new tests, rebaselined existing test. 21 22 * editing/MarkupAccumulator.h: 23 1 24 2016-09-21 Anders Carlsson <andersca@apple.com> 2 25 -
trunk/Source/WebCore/editing/MarkupAccumulator.h
r191671 r206240 55 55 EntityMaskInHTMLPCDATA = EntityMaskInPCDATA | EntityNbsp, 56 56 EntityMaskInAttributeValue = EntityAmp | EntityLt | EntityGt | EntityQuot, 57 EntityMaskInHTMLAttributeValue = Entity MaskInAttributeValue| EntityNbsp,57 EntityMaskInHTMLAttributeValue = EntityAmp | EntityQuot | EntityNbsp, 58 58 }; 59 59
Note: See TracChangeset
for help on using the changeset viewer.
