Context Navigation

← Previous Changeset
Next Changeset →

Changeset 206267 in webkit

Timestamp:

Sep 22, 2016 11:59:47 AM (8 years ago)

Author:

Joseph Pecoraro

Message:

Remove a bunch of unnecessary includes
https://bugs.webkit.org/show_bug.cgi?id=162376

Reviewed by Mark Lam.

Location:

trunk/Source/JavaScriptCore

Files:

: 53 edited

API/JSObjectRef.cpp (modified) (3 diffs)
API/tests/FunctionOverridesTest.cpp (modified) (1 diff)
API/tests/GlobalContextWithFinalizerTest.cpp (modified) (1 diff)
ChangeLog (modified) (1 diff)
bytecode/CallLinkStatus.h (modified) (1 diff)
bytecode/CodeBlock.h (modified) (3 diffs)
bytecode/CodeOrigin.h (modified) (1 diff)
bytecode/SpeculatedType.cpp (modified) (1 diff)
bytecode/UnlinkedCodeBlock.h (modified) (2 diffs)
bytecode/ValueProfile.h (modified) (1 diff)
bytecompiler/NodesCodegen.cpp (modified) (2 diffs)
dfg/DFGByteCodeParser.cpp (modified) (1 diff)
dfg/DFGOperations.cpp (modified) (2 diffs)
dfg/DFGSpeculativeJIT32_64.cpp (modified) (1 diff)
ftl/FTLAbstractHeapRepository.cpp (modified) (1 diff)
heap/CodeBlockSet.cpp (modified) (1 diff)
heap/CodeBlockSet.h (modified) (1 diff)
heap/MarkedSpace.cpp (modified) (1 diff)
inspector/JSJavaScriptCallFramePrototype.cpp (modified) (1 diff)
interpreter/CallFrame.cpp (modified) (1 diff)
interpreter/Interpreter.cpp (modified) (2 diffs)
interpreter/Interpreter.h (modified) (2 diffs)
interpreter/StackVisitor.cpp (modified) (1 diff)
interpreter/StackVisitor.h (modified) (1 diff)
jit/JIT.cpp (modified) (2 diffs)
jit/JIT.h (modified) (1 diff)
jit/JITOperations.cpp (modified) (1 diff)
jit/ThunkGenerators.h (modified) (1 diff)
llint/LLIntSlowPaths.cpp (modified) (2 diffs)
parser/Nodes.h (modified) (1 diff)
parser/Parser.cpp (modified) (1 diff)
parser/Parser.h (modified) (1 diff)
parser/SourceProvider.cpp (modified) (1 diff)
runtime/ArgList.h (modified) (1 diff)
runtime/ArrayBufferView.cpp (modified) (1 diff)
runtime/Executable.h (modified) (1 diff)
runtime/FunctionPrototype.cpp (modified) (1 diff)
runtime/JSEnvironmentRecord.h (modified) (2 diffs)
runtime/JSGlobalObject.h (modified) (1 diff)
runtime/JSLexicalEnvironment.h (modified) (1 diff)
runtime/JSPropertyNameEnumerator.h (modified) (1 diff)
runtime/JSSegmentedVariableObject.h (modified) (2 diffs)
runtime/MapPrototype.cpp (modified) (1 diff)
runtime/RegExpCachedResult.h (modified) (1 diff)
runtime/RegExpConstructor.cpp (modified) (1 diff)
runtime/RegExpObject.cpp (modified) (2 diffs)
runtime/RegExpPrototype.cpp (modified) (2 diffs)
runtime/SamplingProfiler.cpp (modified) (1 diff)
runtime/SetPrototype.cpp (modified) (1 diff)
runtime/StringObject.cpp (modified) (1 diff)
runtime/StringPrototype.cpp (modified) (3 diffs)
runtime/StructureIDTable.cpp (modified) (1 diff)
runtime/VM.cpp (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/Source/JavaScriptCore/API/JSObjectRef.cpp

-                      r205666
+                      r206267
 #include "APICast.h"
 #include "APIUtils.h"
-#include "ButterflyInlines.h"
-#include "CodeBlock.h"
 #include "DateConstructor.h"
 #include "ErrorConstructor.h"
 …
 #include "JSAPIWrapperObject.h"
 #include "JSArray.h"
+#include "JSCInlines.h"
 #include "JSCallbackConstructor.h"
 #include "JSCallbackFunction.h"
 …
 #include "ObjectConstructor.h"
 #include "ObjectPrototype.h"
-#include "JSCInlines.h"
 #include "PropertyNameArray.h"
 #include "RegExpConstructor.h"

trunk/Source/JavaScriptCore/API/tests/FunctionOverridesTest.cpp

r202737	r206267
33	33	#include "Options.h"
34	34	#include <string>
35		~~#include <wtf/text/StringBuilder.h>~~
36	35
37	36	using JSC::Options;

trunk/Source/JavaScriptCore/API/tests/GlobalContextWithFinalizerTest.cpp

r181806	r206267
28	28
29	29	#include "JavaScriptCore.h"
30		~~#include <wtf/DataLog.h>~~
31	30
32	31	static bool failed = true;

trunk/Source/JavaScriptCore/ChangeLog

-                      r206245
+                      r206267
+-09-22  Joseph Pecoraro  <pecoraro@apple.com>
+        Remove a bunch of unnecessary includes
+        https://bugs.webkit.org/show_bug.cgi?id=162376
+        Reviewed by Mark Lam.
 -09-21  Keith Miller  <keith_miller@apple.com>

trunk/Source/JavaScriptCore/bytecode/CallLinkStatus.h

r199093	r206267
39	39
40	40	class CodeBlock;
41		~~class ExecutableBase;~~
42	41	class InternalFunction;
43	42	class JSFunction;

trunk/Source/JavaScriptCore/bytecode/CodeBlock.h

-                      r205567
+                      r206267
 #include "JITCode.h"
 #include "JITMathICForwards.h"
-#include "JITWriteBarrier.h"
 #include "JSCell.h"
 #include "JSGlobalObject.h"
 …
 #include "ProfilerJettisonReason.h"
 #include "PutPropertySlot.h"
-#include "RegExpObject.h"
 #include "UnconditionalFinalizer.h"
 #include "ValueProfile.h"
 …
 class RegisterAtOffsetList;
 class StructureStubInfo;
-class TypeLocation;
 enum class AccessType : int8_t;

trunk/Source/JavaScriptCore/bytecode/CodeOrigin.h

-                      r204466
+                      r206267
 namespace JSC {
+class CodeBlock;
+struct DumpContext;
 struct InlineCallFrame;
-class ExecState;
-class ScriptExecutable;
-class JSFunction;
 struct CodeOrigin {

trunk/Source/JavaScriptCore/bytecode/SpeculatedType.cpp

-                      r206147
+                      r206267
 #include "DirectArguments.h"
+#include "JSArray.h"
 #include "JSCInlines.h"
-#include "JSArray.h"
 #include "JSFunction.h"
 #include "JSMap.h"
 #include "JSSet.h"
 #include "ProxyObject.h"
+#include "RegExpObject.h"
 #include "ScopedArguments.h"
 #include "StringObject.h"

trunk/Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.h

-                      r205462
+                      r206267
 class FunctionMetadataNode;
 class FunctionExecutable;
-class JSScope;
 class ParserError;
 class ScriptExecutable;
 …
     } u;
 };
-class BytecodeGeneratorification;
 class UnlinkedCodeBlock : public JSCell {

trunk/Source/JavaScriptCore/bytecode/ValueProfile.h

r203537	r206267
42	42	namespace JSC {
43	43
44		~~class CCallHelpers;~~
45
46	44	template<unsigned numberOfBucketsArgument>
47	45	struct ValueProfileBase {

trunk/Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp

-                      r206239
+                      r206267
 #include "CallFrame.h"
 #include "JIT.h"
+#include "JSCInlines.h"
 #include "JSFunction.h"
 #include "JSGeneratorFunction.h"
 …
 #include "LabelScope.h"
 #include "Lexer.h"
-#include "JSCInlines.h"
-#include "JSTemplateRegistryKey.h"
 #include "Parser.h"
-#include "PropertyNameArray.h"
-#include "RegExpCache.h"
-#include "RegExpObject.h"
 #include "StackAlignment.h"
-#include "TemplateRegistryKey.h"
 #include <wtf/Assertions.h>
 #include <wtf/Threading.h>
+#include <wtf/text/StringBuilder.h>
 using namespace WTF;

trunk/Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp

r206136	r206267
45	45	#include "Heap.h"
46	46	#include "JSCInlines.h"
47		~~#include "JSLexicalEnvironment.h"~~
48	47	#include "JSModuleEnvironment.h"
49	48	#include "NumberConstructor.h"

trunk/Source/JavaScriptCore/dfg/DFGOperations.cpp

-                      r206136
+                      r206267
 #include "FTLForOSREntryJITCode.h"
 #include "FTLOSREntry.h"
-#include "GetterSetter.h"
 #include "HasOwnPropertyCache.h"
 #include "HostCallReturnValue.h"
 …
 #include "JSSet.h"
 #include "ObjectConstructor.h"
+#include "RegExpObject.h"
 #include "Repatch.h"
 #include "ScopedArguments.h"

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp

r206149	r206267
41	41	#include "HashMapImpl.h"
42	42	#include "JSEnvironmentRecord.h"
43		~~#include "JSLexicalEnvironment.h"~~
44	43	#include "JSPropertyNameEnumerator.h"
45	44	#include "ObjectPrototype.h"

trunk/Source/JavaScriptCore/ftl/FTLAbstractHeapRepository.cpp

r199076	r206267
36	36	#include "FTLState.h"
37	37	#include "GetterSetter.h"
38		~~#include "JSEnvironmentRecord.h"~~
39	38	#include "JSPropertyNameEnumerator.h"
40	39	#include "JSScope.h"

trunk/Source/JavaScriptCore/heap/CodeBlockSet.cpp

r194840	r206267
29	29	#include "CodeBlock.h"
30	30	#include "JSCInlines.h"
31		~~#include "SlotVisitor.h"~~
32	31	#include <wtf/CommaPrinter.h>
33	32

trunk/Source/JavaScriptCore/heap/CodeBlockSet.h

r204466	r206267
40	40	class Heap;
41	41	class JSCell;
42		~~class SlotVisitor;~~
43	42
44	43	// CodeBlockSet tracks all CodeBlocks. Every CodeBlock starts out with one

trunk/Source/JavaScriptCore/heap/MarkedSpace.cpp

r206172	r206267
26	26	#include "JSCInlines.h"
27	27	#include "MarkedBlockInlines.h"
28		~~#include "SuperSampler.h"~~
29	28	#include <wtf/ListDump.h>
30	29

trunk/Source/JavaScriptCore/inspector/JSJavaScriptCallFramePrototype.cpp

r205198	r206267
28	28
29	29	#include "Error.h"
30		~~#include "GetterSetter.h"~~
31	30	#include "Identifier.h"
32	31	#include "JSCInlines.h"

trunk/Source/JavaScriptCore/interpreter/CallFrame.cpp

r203081	r206267
30	30	#include "InlineCallFrame.h"
31	31	#include "Interpreter.h"
32		~~#include "JSLexicalEnvironment.h"~~
33	32	#include "JSCInlines.h"
34	33	#include "VMEntryScope.h"

trunk/Source/JavaScriptCore/interpreter/Interpreter.cpp

-                      r205569
+                      r206267
 #include "Exception.h"
 #include "ExceptionHelpers.h"
-#include "GetterSetter.h"
 #include "JSArrayInlines.h"
 #include "JSBoundFunction.h"
 …
 #include "ProtoCallFrame.h"
 #include "RegExpObject.h"
-#include "RegExpPrototype.h"
 #include "Register.h"
 #include "ScopedArguments.h"

trunk/Source/JavaScriptCore/interpreter/Interpreter.h

-                      r205569
+                      r206267
 #include "JSObject.h"
 #include "Opcode.h"
-#include "SourceProvider.h"
 #include "StackAlignment.h"
 #include "StackFrame.h"
-#include "ThrowScope.h"
 #include <wtf/HashMap.h>
-#include <wtf/text/StringBuilder.h>
 #if !ENABLE(JIT)
 …
     class CodeBlock;
     class EvalExecutable;
-    class ExecutableBase;
     class FunctionExecutable;
     class VM;

trunk/Source/JavaScriptCore/interpreter/StackVisitor.cpp

r204010	r206267
33	33	#include "Interpreter.h"
34	34	#include "JSCInlines.h"
35		#include <wtf/~~DataLog~~.h>
	35	#include <wtf/text/StringBuilder.h>
36	36
37	37	namespace JSC {

trunk/Source/JavaScriptCore/interpreter/StackVisitor.h

r201646	r206267
41	41	class JSFunction;
42	42	class JSObject;
43		~~class JSScope;~~
44	43	class ClonedArguments;
45	44	class Register;

trunk/Source/JavaScriptCore/jit/JIT.cpp

-                      r206098
+                      r206267
 #include "JITOperations.h"
 #include "JSArray.h"
+#include "JSCInlines.h"
 #include "JSFunction.h"
 #include "LinkBuffer.h"
 #include "MaxFrameExtentForSlowPathCall.h"
-#include "JSCInlines.h"
 #include "PCToCodeOriginMap.h"
 #include "ProfilerDatabase.h"
 …
 #include "SlowPathCall.h"
 #include "StackAlignment.h"
-#include "SuperSampler.h"
 #include "TypeProfilerLog.h"
 #include <wtf/CryptographicallyRandomNumber.h>

trunk/Source/JavaScriptCore/jit/JIT.h

r206098	r206267
59	59	class Identifier;
60	60	class Interpreter;
61		~~class JSScope;~~
62	61	class MarkedAllocator;
63	62	class Register;

trunk/Source/JavaScriptCore/jit/JITOperations.cpp

r205675	r206267
57	57	#include "PolymorphicAccess.h"
58	58	#include "PropertyName.h"
	59	#include "RegExpObject.h"
59	60	#include "Repatch.h"
60	61	#include "ScopedArguments.h"

trunk/Source/JavaScriptCore/jit/ThunkGenerators.h

r200208	r206267
34	34
35	35	class CallLinkInfo;
36		~~class CCallHelpers;~~
37	36
38	37	MacroAssemblerCodeRef throwExceptionFromCallSlowPathGenerator(VM*);

trunk/Source/JavaScriptCore/llint/LLIntSlowPaths.cpp

-                      r205569
+                      r206267
 #include "JITExceptions.h"
 #include "JITWorklist.h"
-#include "JSLexicalEnvironment.h"
 #include "JSCInlines.h"
 #include "JSCJSValue.h"
 #include "JSGeneratorFunction.h"
 #include "JSGlobalObjectFunctions.h"
+#include "JSLexicalEnvironment.h"
 #include "JSString.h"
 #include "JSWithScope.h"
 …
 #include "ObjectPropertyConditionSet.h"
 #include "ProtoCallFrame.h"
+#include "RegExpObject.h"
 #include "ShadowChicken.h"
 #include "StructureRareDataInlines.h"

trunk/Source/JavaScriptCore/parser/Nodes.h

-                      r206239
+                      r206267
     class FunctionParameters;
     class Label;
+    class ModuleAnalyzer;
+    class ModuleScopeData;
     class PropertyListNode;
     class ReadModifyResolveNode;
     class RegisterID;
-    class JSScope;
     class ScopeNode;
-    class ModuleAnalyzer;
-    class ModuleScopeData;
     typedef SmallPtrSet<UniquedStringImpl*> UniquedStringImplPtrSet;

trunk/Source/JavaScriptCore/parser/Parser.cpp

r205969	r206267
27	27	#include "JSCInlines.h"
28	28	#include "SetForScope.h"
29		~~#include "SourceProvider.h"~~
30	29	#include "VM.h"
31	30	#include <utility>

trunk/Source/JavaScriptCore/parser/Parser.h

-                      r204994
+                      r206267
 namespace JSC {
-class ExecState;
 class FunctionMetadataNode;
 class FunctionParameters;
 class Identifier;
 class VM;
-class ProgramNode;
 class SourceCode;
 class SyntaxChecker;

trunk/Source/JavaScriptCore/parser/SourceProvider.cpp

r188169	r206267
29	29	#include "JSCInlines.h"
30	30	#include <wtf/Lock.h>
31		~~#include <wtf/StdLibExtras.h>~~
32	31
33	32	namespace JSC {

trunk/Source/JavaScriptCore/runtime/ArgList.h

-                      r204572
+                      r206267
 #include "CallFrame.h"
-#include "Register.h"
 #include <wtf/HashSet.h>
 namespace JSC {
-class SlotVisitor;
 class MarkedArgumentBuffer {

trunk/Source/JavaScriptCore/runtime/ArrayBufferView.cpp

r165676	r206267
26	26	#include "config.h"
27	27	#include "ArrayBufferView.h"
28
29		~~#include "ArrayBuffer.h"~~
30	28
31	29	namespace JSC {

trunk/Source/JavaScriptCore/runtime/Executable.h

-                      r205856
+                      r206267
 class JSWASMModule;
 class LLIntOffsetsExtractor;
+class ModuleProgramCodeBlock;
 class ProgramCodeBlock;
-class ModuleProgramCodeBlock;
-class JSScope;
 class WebAssemblyCodeBlock;
-class ModuleProgramCodeBlock;
-class JSModuleRecord;
-class JSScope;
 enum CompilationKind { FirstCompilation, OptimizingCompilation };

trunk/Source/JavaScriptCore/runtime/FunctionPrototype.cpp

-                      r205856
+                      r206267
 #include "BuiltinExecutables.h"
 #include "BuiltinNames.h"
-#include "ClonedArguments.h"
 #include "Error.h"
 #include "GetterSetter.h"
 #include "JSArray.h"
-#include "JSBoundFunction.h"
 #include "JSFunction.h"
 #include "JSGlobalObjectFunctions.h"

trunk/Source/JavaScriptCore/runtime/JSEnvironmentRecord.h

-                      r197712
+                      r206267
 #include "JSObject.h"
 #include "JSSymbolTableObject.h"
-#include "Register.h"
 #include "SymbolTable.h"
 …
 class LLIntOffsetsExtractor;
-class Register;
 class JSEnvironmentRecord : public JSSymbolTableObject {

trunk/Source/JavaScriptCore/runtime/JSGlobalObject.h

r205856	r206267
65	65	class EvalCodeBlock;
66	66	class EvalExecutable;
67		~~class FunctionCodeBlock;~~
68		~~class FunctionExecutable;~~
69	67	class FunctionPrototype;
70	68	class GeneratorPrototype;

trunk/Source/JavaScriptCore/runtime/JSLexicalEnvironment.h

r205666	r206267
36	36	namespace JSC {
37	37
38		~~class Register;~~
39
40	38	class JSLexicalEnvironment : public JSEnvironmentRecord {
41	39	protected:

trunk/Source/JavaScriptCore/runtime/JSPropertyNameEnumerator.h

r205569	r206267
33	33
34	34	namespace JSC {
35
36		~~class Identifier;~~
37	35
38	36	class JSPropertyNameEnumerator final : public JSCell {

trunk/Source/JavaScriptCore/runtime/JSSegmentedVariableObject.h

-                      r197712
+                      r206267
 #include "JSObject.h"
 #include "JSSymbolTableObject.h"
-#include "Register.h"
 #include "SymbolTable.h"
 #include <wtf/SegmentedVector.h>
 …
 class LLIntOffsetsExtractor;
-class Register;
 // This is a mostly drop-in replacement for JSEnvironmentRecord, except that it preserves

trunk/Source/JavaScriptCore/runtime/MapPrototype.cpp

r206104	r206267
30	30	#include "Error.h"
31	31	#include "ExceptionHelpers.h"
32		~~#include "GetterSetter.h"~~
33	32	#include "IteratorOperations.h"
34	33	#include "JSCInlines.h"

trunk/Source/JavaScriptCore/runtime/RegExpCachedResult.h

r199075	r206267
28	28
29	29	#include "RegExpObject.h"
30		~~#include "SuperSampler.h"~~
31	30
32	31	namespace JSC {

trunk/Source/JavaScriptCore/runtime/RegExpConstructor.cpp

r205569	r206267
26	26	#include "GetterSetter.h"
27	27	#include "JSCInlines.h"
28		~~#include "RegExpMatchesArray.h"~~
29	28	#include "RegExpPrototype.h"
30	29	#include "StructureInlines.h"

trunk/Source/JavaScriptCore/runtime/RegExpObject.cpp

-                      r205666
+                      r206267
 #include "RegExpObject.h"
-#include "ButterflyInlines.h"
 #include "Error.h"
 #include "ExceptionHelpers.h"
 …
 #include "JSCInlines.h"
 #include "RegExpConstructor.h"
-#include "RegExpMatchesArray.h"
 #include "RegExpObjectInlines.h"
-#include "RegExpPrototype.h"
 namespace JSC {

trunk/Source/JavaScriptCore/runtime/RegExpPrototype.cpp

-                      r205569
+                      r206267
 #include "JSArray.h"
 #include "JSCBuiltins.h"
+#include "JSCInlines.h"
 #include "JSCJSValue.h"
 #include "JSFunction.h"
 …
 #include "Lexer.h"
 #include "ObjectPrototype.h"
-#include "JSCInlines.h"
-#include "RegExpObject.h"
 #include "RegExp.h"
 #include "RegExpCache.h"
 #include "RegExpConstructor.h"
 #include "RegExpMatchesArray.h"
+#include "RegExpObject.h"
 #include "StringObject.h"
 #include "StringRecursionChecker.h"
+#include <wtf/text/StringBuilder.h>
 namespace JSC {

trunk/Source/JavaScriptCore/runtime/SamplingProfiler.cpp

r206154	r206267
52	52	#include <wtf/RandomNumber.h>
53	53	#include <wtf/RefPtr.h>
	54	#include <wtf/text/StringBuilder.h>
54	55
55	56	namespace JSC {

trunk/Source/JavaScriptCore/runtime/SetPrototype.cpp

r206104	r206267
30	30	#include "Error.h"
31	31	#include "ExceptionHelpers.h"
32		~~#include "GetterSetter.h"~~
33	32	#include "IteratorOperations.h"
34	33	#include "JSCInlines.h"

trunk/Source/JavaScriptCore/runtime/StringObject.cpp

r205569	r206267
26	26	#include "JSCInlines.h"
27	27	#include "PropertyNameArray.h"
28		~~#include "Reject.h"~~
29	28
30	29	namespace JSC {

trunk/Source/JavaScriptCore/runtime/StringPrototype.cpp

-                      r205666
+                      r206267
 #include "Executable.h"
 #include "IntlObject.h"
+#include "JSArray.h"
 #include "JSCBuiltins.h"
 #include "JSCInlines.h"
+#include "JSFunction.h"
 #include "JSGlobalObjectFunctions.h"
-#include "JSArray.h"
-#include "JSFunction.h"
 #include "JSStringBuilder.h"
 #include "JSStringIterator.h"
 …
 #include "RegExpCache.h"
 #include "RegExpConstructor.h"
-#include "RegExpMatchesArray.h"
 #include "RegExpObject.h"
 #include "SuperSampler.h"
 …
 #include <wtf/ASCIICType.h>
 #include <wtf/MathExtras.h>
+#include <wtf/text/StringBuilder.h>
 #include <wtf/text/StringView.h>
 #include <wtf/unicode/Collator.h>

trunk/Source/JavaScriptCore/runtime/StructureIDTable.cpp

r194496	r206267
29	29	#include <limits.h>
30	30	#include <wtf/Atomics.h>
31		~~#include <wtf/DataLog.h>~~
32	31
33	32	namespace JSC {

trunk/Source/JavaScriptCore/runtime/VM.cpp

r206136	r206267
65	65	#include "JSGlobalObjectFunctions.h"
66	66	#include "JSInternalPromiseDeferred.h"
67		~~#include "JSLexicalEnvironment.h"~~
68	67	#include "JSLock.h"
69	68	#include "JSMap.h"

Note: See TracChangeset for help on using the changeset viewer.

Context Navigation

Changeset 206267 in webkit

Legend:

Download in other formats: