Changeset 206299 in webkit


Ignore:
Timestamp:
Sep 23, 2016 7:16:57 AM (8 years ago)
Author:
Alan Bujtas
Message:

Replace redundant prepareForDestruction() call with RELEASE_ASSERT in Document::removedLastRef.
https://bugs.webkit.org/show_bug.cgi?id=162467

Reviewed by Chris Dumez.

Since r205786 fixed the root cause of webkit.org/b/159372, we no longer need the workaround.
Replace it with a RELEASE_ASSERT to ensure clean state.

No new tests, covered by existing test.

  • dom/Document.cpp:

(WebCore::Document::removedLastRef):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r206296 r206299  
     12016-09-22  Zalan Bujtas  <zalan@apple.com>
     2
     3        Replace redundant prepareForDestruction() call with RELEASE_ASSERT in Document::removedLastRef.
     4        https://bugs.webkit.org/show_bug.cgi?id=162467
     5
     6        Reviewed by Chris Dumez.
     7
     8        Since r205786 fixed the root cause of webkit.org/b/159372, we no longer need the workaround.
     9        Replace it with a RELEASE_ASSERT to ensure clean state.
     10
     11        No new tests, covered by existing test.
     12
     13        * dom/Document.cpp:
     14        (WebCore::Document::removedLastRef):
     15
    1162016-09-23  Antoine Quint  <graouts@apple.com>
    217
  • trunk/Source/WebCore/dom/Document.cpp

    r206230 r206299  
    669669        incrementReferencingNodeCount();
    670670
    671         prepareForDestruction();
     671        RELEASE_ASSERT(!hasLivingRenderTree());
    672672        // We must make sure not to be retaining any of our children through
    673673        // these extra pointers or we will create a reference cycle.
Note: See TracChangeset for help on using the changeset viewer.