Changeset 206684 in webkit

Timestamp:

Sep 30, 2016, 3:38:58 PM (10 years ago)

Author:

beidson@apple.com

Message:

REGRESSION (Safari 10 combined with WK changes): Unable to store WebCrypto keys in IndexedDB database.
<rdar://problem/28334440> and ​https://bugs.webkit.org/show_bug.cgi?id=162554

Reviewed by Alexey Proskuryakov.

Safari 10 has a WKPageNavigation client but does not implement the "copyWebCryptoMasterKey" callback.

WebKit just fails in this case, instead of falling back to "getDefaultWebCryptoMasterKey".
It should fall back.

Additionally there's a WKContextClient callback to get the crypto key, also, but it is completely unused.
So it should be pulled.

• UIProcess/API/APILoaderClient.h:

(API::LoaderClient::webCryptoMasterKey): Deleted.

• UIProcess/API/C/WKContext.h:

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient):
(WKPageSetPageNavigationClient): If the client doesn't implement this method, fallback to getDefaultWebCryptoMasterKey.

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::webCryptoMasterKey): If the client doesn't implement this method,

fallback to getDefaultWebCryptoMasterKey.

• UIProcess/WebContextClient.cpp:

(WebKit::WebContextClient::copyWebCryptoMasterKey): Deleted.

• UIProcess/WebContextClient.h:

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::wrapCryptoKey): Only ask the NavigationClient before falling back. Don't ask the loader client.
(WebKit::WebPageProxy::unwrapCryptoKey): Ditto.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/APILoaderClient.h (modified) (1 diff)
• UIProcess/API/C/WKContext.h (modified) (2 diffs)
• UIProcess/API/C/WKPage.cpp (modified) (3 diffs)
• UIProcess/Cocoa/NavigationState.mm (modified) (2 diffs)
• UIProcess/WebContextClient.cpp (modified) (2 diffs)
• UIProcess/WebContextClient.h (modified) (2 diffs)
• UIProcess/WebPageProxy.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2016-09-30  Brady Eidson  <beidson@apple.com>
+
+        REGRESSION (Safari 10 combined with WK changes): Unable to store WebCrypto keys in IndexedDB database.
+        <rdar://problem/28334440> and https://bugs.webkit.org/show_bug.cgi?id=162554
+
+        Reviewed by Alexey Proskuryakov.
+
+        Safari 10 has a WKPageNavigation client but does not implement the "copyWebCryptoMasterKey" callback.
+
+        WebKit just fails in this case, instead of falling back to "getDefaultWebCryptoMasterKey".
+        It should fall back.
+
+        Additionally there's a WKContextClient callback to get the crypto key, also, but it is completely unused.
+        So it should be pulled.
+
+        * UIProcess/API/APILoaderClient.h:
+        (API::LoaderClient::webCryptoMasterKey): Deleted.
+        * UIProcess/API/C/WKContext.h:
+
+        * UIProcess/API/C/WKPage.cpp:
+        (WKPageSetPageLoaderClient):
+        (WKPageSetPageNavigationClient): If the client doesn't implement this method, fallback to getDefaultWebCryptoMasterKey.
+
+        * UIProcess/Cocoa/NavigationState.mm:
+        (WebKit::NavigationState::NavigationClient::webCryptoMasterKey): If the client doesn't implement this method,
+          fallback to getDefaultWebCryptoMasterKey.
+
+        * UIProcess/WebContextClient.cpp:
+        (WebKit::WebContextClient::copyWebCryptoMasterKey): Deleted.
+        * UIProcess/WebContextClient.h:
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::wrapCryptoKey): Only ask the NavigationClient before falling back. Don't ask the loader client.
+        (WebKit::WebPageProxy::unwrapCryptoKey): Ditto.
+
 2016-09-30  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/APILoaderClient.h

@@ -94 +94 @@
     virtual void willGoToBackForwardListItem(WebKit::WebPageProxy&, WebKit::WebBackForwardListItem*, API::Object*) { }
 
-    virtual RefPtr<Data> webCryptoMasterKey(WebKit::WebPageProxy&) { return nullptr; }
-
     virtual void didNavigateWithNavigationData(WebKit::WebPageProxy&, const WebKit::WebNavigationDataStore&, WebKit::WebFrameProxy&) { }
     virtual void didPerformClientRedirect(WebKit::WebPageProxy&, const WTF::String&, const WTF::String&, WebKit::WebFrameProxy&) { }

trunk/Source/WebKit2/UIProcess/API/C/WKContext.h

@@ -76 +76 @@
 
     // Version 1.
-    WKContextCopyWebCryptoMasterKeyCallback                             copyWebCryptoMasterKey;
+    void                                                                (*copyWebCryptoMasterKey_unavailable)(void);
 } WKContextClientV1;
 
@@ -88 +88 @@
 
     // Version 1.
-    WKContextCopyWebCryptoMasterKeyCallback                             copyWebCryptoMasterKey;
+    void                                                                (*copyWebCryptoMasterKey_unavailable)(void);
 
     // Version 2.

trunk/Source/WebKit2/UIProcess/API/C/WKPage.cpp

@@ -73 +73 @@
 #include <WebCore/Page.h>
 #include <WebCore/SecurityOriginData.h>
+#include <WebCore/SerializedCryptoKeyWrap.h>
 #include <WebCore/WindowFeatures.h>
 
@@ -1214 +1215 @@
             if (m_client.willGoToBackForwardListItem)
                 m_client.willGoToBackForwardListItem(toAPI(&page), toAPI(item), toAPI(userData), m_client.base.clientInfo);
-        }
-
-        RefPtr<API::Data> webCryptoMasterKey(WebPageProxy& page) override
-        {
-            return page.process().processPool().client().copyWebCryptoMasterKey(&page.process().processPool());
         }
 
@@ -2328 +2324 @@
         RefPtr<API::Data> webCryptoMasterKey(WebPageProxy& page) override
         {
-            if (!m_client.copyWebCryptoMasterKey)
+            if (m_client.copyWebCryptoMasterKey)
+                return adoptRef(toImpl(m_client.copyWebCryptoMasterKey(toAPI(&page), m_client.base.clientInfo)));
+
+            Vector<uint8_t> masterKey;
+            if (!getDefaultWebCryptoMasterKey(masterKey))
                 return nullptr;
-            return adoptRef(toImpl(m_client.copyWebCryptoMasterKey(toAPI(&page), m_client.base.clientInfo)));
+
+            return API::Data::create(masterKey.data(), masterKey.size());
         }
 

trunk/Source/WebKit2/UIProcess/Cocoa/NavigationState.mm

@@ -65 +65 @@
 #import <WebCore/Credential.h>
 #import <WebCore/SecurityOriginData.h>
+#import <WebCore/SerializedCryptoKeyWrap.h>
 #import <WebCore/URL.h>
 #import <wtf/NeverDestroyed.h>
@@ -720 +721 @@
 RefPtr<API::Data> NavigationState::NavigationClient::webCryptoMasterKey(WebKit::WebPageProxy&)
 {
-    if (!m_navigationState.m_navigationDelegateMethods.webCryptoMasterKeyForWebView)
-        return nullptr;
+    if (!m_navigationState.m_navigationDelegateMethods.webCryptoMasterKeyForWebView) {
+        Vector<uint8_t> masterKey;
+        if (!getDefaultWebCryptoMasterKey(masterKey))
+            return nullptr;
+
+        return API::Data::create(masterKey.data(), masterKey.size());
+    }
 
     auto navigationDelegate = m_navigationState.m_navigationDelegate.get();

trunk/Source/WebKit2/UIProcess/WebContextClient.cpp

@@ -27 +27 @@
 #include "WebContextClient.h"
 
-#include "APIArray.h"
 #include "WebProcessPool.h"
 
@@ -56 +55 @@
 }
 
-PassRefPtr<API::Data> WebContextClient::copyWebCryptoMasterKey(WebProcessPool* processPool)
-{
-    if (!m_client.copyWebCryptoMasterKey)
-        return nullptr;
-
-    return adoptRef(toImpl(m_client.copyWebCryptoMasterKey(toAPI(processPool), m_client.base.clientInfo)));
-}
-
 } // namespace WebKit

trunk/Source/WebKit2/UIProcess/WebContextClient.h

@@ -32 +32 @@
 
 namespace API {
-class Array;
-
 template<> struct ClientTraits<WKContextClientBase> {
     typedef std::tuple<WKContextClientV0, WKContextClientV1, WKContextClientV2> Versions;
@@ -49 +47 @@
     void networkProcessDidCrash(WebProcessPool*);
     void databaseProcessDidCrash(WebProcessPool*);
-    PassRefPtr<API::Data> copyWebCryptoMasterKey(WebProcessPool*);
 };
 

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -6146 +6146 @@
         if (RefPtr<API::Data> keyData = m_navigationClient->webCryptoMasterKey(*this))
             masterKey = keyData->dataReference().vector();
-    } else if (RefPtr<API::Data> keyData = m_loaderClient->webCryptoMasterKey(*this))
-        masterKey = keyData->dataReference().vector();
-    else if (!getDefaultWebCryptoMasterKey(masterKey)) {
+    } else if (!getDefaultWebCryptoMasterKey(masterKey)) {
         succeeded = false;
         return;
@@ -6165 +6163 @@
         if (RefPtr<API::Data> keyData = m_navigationClient->webCryptoMasterKey(*this))
             masterKey = keyData->dataReference().vector();
-    } else if (RefPtr<API::Data> keyData = m_loaderClient->webCryptoMasterKey(*this))
-        masterKey = keyData->dataReference().vector();
-    else if (!getDefaultWebCryptoMasterKey(masterKey)) {
+    } else if (!getDefaultWebCryptoMasterKey(masterKey)) {
         succeeded = false;
         return;